Added Device get_question_by_id, and always fetch template before data to ensure we do not get None

[mikelgg93]

Added Device.get_question_by_id(), and always fetch template before data to ensure we do not get None.

[dourvaris]

Instead of making a new http call every time someone calls this function, I'd first check if the question id is in the current self.template_definition and only update it if that's not the case.

[mikelgg93]

async def get_question_by_id(self, question_id: T.Union[str, UUID]):
        item = (
            self.template_definition.get_question_by_id(question_id)
            if self.template_definition
            else None
        )

        if item:
            return item

        old_template = self.template_definition if self.template_definition else None

        await self.get_template()

        if (
            self.template_definition is not None
            and self.template_definition is not old_template
        ):
            return self.template_definition.get_question_by_id(question_id)

        return None

Something like this? where we check first if the question_id is in the template already set, if it is not set or not found (assuming you changed it in between), we fetch it and then try again