Additional type mappings to fluently pass outputs as inputs elsewhere #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnstoppableMango
previously approved these changes
Mar 19, 2024
There was a problem hiding this comment.
LGTM, however I'm not sure this fully resolves #80. I think the properties on talos:machine/generated:Certificates still have mismatched underscores. I was able to replicate this in a different repo.
No changes needed here, just wanted to make that callout in regards to #80
|
@UnstoppableMango I will check and add more fixes to this PR so it resolves #80 as well. |
|
@UnstoppableMango a quick check about the underscores makes me think this is a TF-bridge issue. I removed |
UnstoppableMango
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90
The main changes are in
provider/resources.go. All the other changes are changes due to regenerating the SDKs.