Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove top-level pf folder #2653

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove top-level pf folder #2653

wants to merge 1 commit into from

Conversation

guineveresaenger
Copy link
Contributor

@guineveresaenger guineveresaenger commented Nov 21, 2024

We have migrated the PF functionality to live inside of pkg/pf instead of its own module.

This pull request removes the deprecated files.

Reference:
#2480
pulumi/ci-mgmt#1103

@guineveresaenger guineveresaenger requested a review from a team November 21, 2024 16:55
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.97%. Comparing base (c7d87ed) to head (02367c5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2653   +/-   ##
=======================================
  Coverage   69.97%   69.97%           
=======================================
  Files         367      367           
  Lines       44504    44504           
=======================================
+ Hits        31141    31142    +1     
- Misses      11734    11735    +1     
+ Partials     1629     1627    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@blampe
Copy link
Contributor

blampe commented Nov 21, 2024

There are still a couple things to do before it's "safe" to remove this:

  1. Cut one final pf/... (and x/... and testing/..) tag so users will pick up the "Deprecated" tag on the module.
  2. Wait a sufficiently long amount of time for users to notice pf is deprecated and point at the new module.

Step (2) means technically we might want to keep this around forever to avoid breaking third-parties years from now.

@guineveresaenger guineveresaenger added the blocked The issue cannot be resolved without 3rd party action. label Nov 21, 2024
@guineveresaenger
Copy link
Contributor Author

Summary of internal discussion:

  • Cut a final deprecated release for pf
  • Then remove this code(?)

Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to wait at least one more release, then verify that this won't break people before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked The issue cannot be resolved without 3rd party action.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants