Commit to XSkipDetailedDiffForChanges

[t0yv0]

See what happens with the tests if we commit to XSkipDetailedDiffForChanges without a flag.

[codecov]

Codecov Report

Merging #1510 (cd5f02b) into master (b4f028a) will decrease coverage by 4.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1510      +/-   ##
==========================================
- Coverage   62.01%   57.96%   -4.05%     
==========================================
  Files         184      286     +102     
  Lines       32862    39635    +6773     
==========================================
+ Hits        20379    22974    +2595     
- Misses      11345    15324    +3979     
- Partials     1138     1337     +199     

Files	Coverage Δ
pkg/tfbridge/provider.go	48.85% <100.00%> (ø)

... and 103 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

[t0yv0]

pulumi/pulumi-aws#2963 failed TestMigrateRdsInstance. Very strange.

[t0yv0]

Azure failed TestAccFrontdoor

error: error: no changes were expected but changes were proposed

pulumi/pulumi-azure#1420

[t0yv0]

pulumi/pulumi-confluentcloud#263

   ~ confluentcloud:index/kafkaCluster:KafkaCluster: (update)
      [id=lkc-x7m1pq]
      [urn=urn:pulumi:p-it-fv-az178-7-py-884f4a11::confluentcloud-basic-kafka-acls::confluentcloud:index/kafkaCluster:KafkaCluster::basic-cluster]
      [provider=urn:pulumi:p-it-fv-az178-7-py-884f4a11::confluentcloud-basic-kafka-acls::pulumi:providers:confluentcloud::default_1_28_0_alpha_1699373197::c8685a80-42c6-4f36-974c-c6a513dd1625]
      availability: "SINGLE_ZONE"
      basic       : {
      }
      cloud       : "AWS"
      displayName : "basic-cluster-eea1395"
      environment : {
          id        : "env-8myryq"
      }
      region      : "us-west-2"

Resources:
~ 1 to update
13 unchanged

[t0yv0]

These are the only failures detected across current tests.

[t0yv0]

• Make Kafka Cluster compatible with XSkipDetailedDiffForChanges pulumi-confluentcloud#264
• Make Frontdoor compatible with XSkipDetailedDiffForChanges pulumi-azure#1421
• AWS is passing on master with the latest iteration

I think the detected failure are fairly peculiar to the involved resources. My recommendation is to proceed with the roll-out.