Upgrade terraform-provider-pagerduty to v3.17.2 #667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulumi-bot
added
the
needs-release/patch
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
github-actions
bot
force-pushed
the
upgrade-terraform-provider-pagerduty-to-v3.17.2-ci
branch
from
45a2e1c
to
ebdfd70
Compare
danielrbradley
added a commit
to pulumi/upgrade-provider
that referenced
this pull request
Nov 12, 2024
Fixes #297 ## Attempt 1 Set PR title before accessing it - We were using the `repo.prTitle` before it was assigned a value which meant it was always an empty string while checking for existing PRs and therefore it never found an existing PR. Set repo explicitly when querying PRs - Rule out possibility that the CLI is looking in the wrong repo. [First test run failed](https://github.com/pulumi/pulumi-pagerduty/actions/runs/11799391121/job/32867773802) because the branch name in CI was always randomized so made the branch name consistent. ## Attempt 2 [Second test run failed](https://github.com/pulumi/pulumi-pagerduty/actions/runs/11799583593/job/32868434462) because although a PR with the same name already exists, attempting to update it based on branch name fails because the branch might have come from somewhere else. Therefore we should move out duplicate check back to using branch name now that branch name is a predictable identifier. See also #290 ## Attempt 3 Use sane, predictable branch names in CI and revert back to identifying existing PRs by branch name - This avoids CI trying to modify user-created PRs. This is more reliable because we're using the same identifier when checking for existence as when we're attempting the update. 1. [First test run](https://github.com/pulumi/pulumi-pagerduty/actions/runs/11799797913) creates a [new PR](pulumi/pulumi-pagerduty#667) as the new stable branch name doesn't yet exist. 2. [Second test run](https://github.com/pulumi/pulumi-pagerduty/actions/runs/11799938725/job/32869663923) updates the existing PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated via
$ upgrade-provider pulumi/pulumi-pagerduty --kind=all --target-version=3.17.2.Fixes Upgrade terraform-provider-pagerduty to v3.17.2 #663
Fixes Upgrade terraform-provider-pagerduty to v3.17.1 #656