Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add synced PCL files to program gen tests #865

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add synced PCL files to program gen tests #865

wants to merge 4 commits into from

Conversation

aq17
Copy link
Contributor

@aq17 aq17 commented Oct 18, 2022

Description

Addresses pu/yaml 251

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@aq17 aq17 added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Oct 18, 2022
@aq17 aq17 requested a review from iwahbe October 18, 2022 17:44
@aq17 aq17 force-pushed the aqiu/pu-yaml-251 branch 2 times, most recently from 6ee4a07 to f6e215a Compare October 18, 2022 18:09
iwahbe
iwahbe reviewed Oct 18, 2022
View reviewed changes
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. The CI is unhappy though.

@aq17
Copy link
Contributor Author

aq17 commented Oct 18, 2022 •
edited
Loading

This looks fine to me. The CI is unhappy though.

Need pulumi/pulumi-yaml#375 to merge and then rerun the sync action

I think https://github.com/pulumi/pulumi/pull/11056/files#diff-860749d2dad497a2e4dbdb2e89ceb7ebc99bed8add0ba1ec6a7009946085d787R376 also needs to land first, so TestProgramCodegen gets the correct path to the PCL files under transpiled_examples

@aq17 aq17 force-pushed the aqiu/pu-yaml-251 branch 2 times, most recently from f6e215a to fb45706 Compare October 18, 2022 22:31
@aq17 aq17 added this to the 0.80 milestone Oct 28, 2022
@aq17 aq17 self-assigned this Oct 28, 2022
@aq17 aq17 force-pushed the aqiu/pu-yaml-251 branch 3 times, most recently from 3bee318 to ccd6376 Compare October 28, 2022 22:01
@aq17 aq17 requested a review from iwahbe October 31, 2022 17:28
iwahbe
iwahbe approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we're missing a schema ([email protected]), but feel free to merge once tests are 🟢.

@aq17 aq17 force-pushed the aqiu/pu-yaml-251 branch 8 times, most recently from e3daf04 to cc81ef5 Compare November 2, 2022 17:41
@aq17 aq17 force-pushed the aqiu/pu-yaml-251 branch 3 times, most recently from 1ad68bf to 03186b5 Compare November 8, 2022 01:13
@AaronFriel AaronFriel modified the milestones: 0.80, 0.81 Nov 15, 2022
@AaronFriel AaronFriel modified the milestones: 0.81, 0.82 Dec 6, 2022
@lukehoban lukehoban removed this from the 0.82 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwahbe iwahbe iwahbe approved these changes

Assignees

@aq17 aq17

Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aq17 @iwahbe @lukehoban @AaronFriel