Fix publishing SDKs to include required attribute for Pulumi.Automation #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonWhall
force-pushed
the
bug/fix-pulumi-install
branch
from
16c760a
to
f72e3cf
Compare
Frassle
approved these changes
Nov 19, 2024
|
I don't think the test failures here are due to this PR, seeing it elsewhere as well. Looking into it. |
|
Hey @JasonWhall if you rebase this on latest main I think we should be able to get the tests passing and get this merged in. |
- Currently when publishing the Pulumi.Automation SDK there is an expected property PulumiSdkVersion which should be set when building the project - This property is set during buildSdk and testPulumiAutomationSdk but not the publishing targets which provide the resulting nuget package. - This means when a consumer references the Automation Api nuget package they have a version that does not have the required property set - Refactored the F# code to ensure the version is set during publish as well - Add null check for version to fail if not found
JasonWhall
force-pushed
the
bug/fix-pulumi-install
branch
from
f72e3cf
to
278957a
Compare
|
@Frassle - Thanks! Re-based |
Closed
|
This PR has been shipped in release v3.69.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when publishing the Pulumi.Automation SDK there is an expected property PulumiSdkVersion which should be set when building the project
This property is set during buildSdk and testPulumiAutomationSdk but not the publishing targets which provide the resulting nuget package.
This means when a consumer references the Automation Api nuget package they have a version that does not have the required property set causing
LocalPulumiCommand.Installto fail.Refactored the F# code to ensure the version is set during publish as well
Fixes #392