Fix the language plugin to return a version #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes `pulumi about` to show the real version instead of `unknown` for the dotnet language plugin. The fix updates `GetPluginInfo` RPC to return the `Version` from the right `version` Go package—the one that's actually being set during build via `ldflags` (`"github.com/pulumi/pulumi-dotnet/pulumi-language-dotnet/version"` instead of `"github.com/pulumi/pulumi/sdk/v3/go/common/version"`, which looks to be a hold over from when this code lived in the pulumi/pulumi repo).
justinvp
force-pushed
the
justin/langhost_version
branch
from
787901f
to
70aa7b2
Compare
tgummerer
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes
pulumi aboutto show the real version instead ofunknownfor the dotnet language plugin.The fix updates
GetPluginInfoto return theVersionfrom the rightversionGo package—the one that's actually being set during build vialdflags("github.com/pulumi/pulumi-dotnet/pulumi-language-dotnet/version"instead of"github.com/pulumi/pulumi/sdk/v3/go/common/version", which looks to be a hold over from when this code lived in the pulumi/pulumi repo).Fixes #389