Fix RunPlugin and CI jobs (#396)

Since pulumi/pulumi#17763 the pwd property is
the working directory, not the program directory. We need to fix up
RunPlugin to use both directories correctly, loading the csproj from the
program directory, but then setting the working directory to pwd.

This also updates the CI jobs to always use the latest version of the
CLI. We were running into issues because different runners happened to
have different CLI versions installed.

For now I've also disabled fail-fast on the integration tests to make
re-running them with flaky tests more likely to pass.

.changes/unreleased/Bug Fixes-395.yaml

@@ -0,0 +1,6 @@
+component: runtime
+kind: Bug Fixes
+body: Fix RunPlugin with new versions of the pulumi cli
+time: 2024-11-20T08:26:38.629389Z
+custom:
+  PR: "395"

.github/workflows/pr.yml

@@ -51,6 +51,8 @@ jobs:
           dotnet-version: ${{ matrix.dotnet-version }}
       - name: Install Pulumi CLI
         uses: pulumi/actions@v5
+        with:
+          pulumi-version: latest
       - name: Build Pulumi SDK
         run: dotnet run build-sdk
       - name: Workspace clean (are xml doc file updates committed?)
@@ -69,6 +71,7 @@ jobs:
           token: ${{ secrets.CODECOV_TOKEN }}
   integration-tests:
     strategy:
+      fail-fast: false
       matrix:
         os: [ubuntu-latest, windows-latest, macos-12]
         dotnet-version: [6.0.x, 8.0.x]
@@ -86,6 +89,8 @@ jobs:
           go-version: 1.22.x
       - name: Install Pulumi CLI
         uses: pulumi/actions@v5
+        with:
+          pulumi-version: latest
       - name: Install gotestsum
         uses: jaxxstorm/[email protected]
         env:

.github/workflows/release-sdk.yml

@@ -49,6 +49,8 @@ jobs:
           dotnet-quality: ga
       - name: Install Pulumi CLI
         uses: pulumi/actions@v5
+        with:
+          pulumi-version: latest
       - name: Build Pulumi SDK
         run: dotnet run build-sdk
       - name: Test Pulumi SDK

Makefile

@@ -6,7 +6,7 @@ install::
 build::
 	cd pulumi-language-dotnet && ${GO} build .
 
-test_integration::
+test_integration:: build
 	cd integration_tests && gotestsum -- --parallel 1 --timeout 30m ./...
 
 .PHONY: install build

pulumi-language-dotnet/main.go

@@ -960,9 +960,12 @@ func (host *dotnetLanguageHost) RunPlugin(
 	default:
 		// Run from source.
 		args = append(args, "run")
-		if req.Program != "" {
-			args = append(args, "--project", req.Program)
+
+		project := req.Info.ProgramDirectory
+		if req.Info.EntryPoint != "" {
+			project = filepath.Join(project, req.Info.EntryPoint)
 		}
+		args = append(args, "--project", project)
 	}
 
 	// Add on all the request args to start this plugin
@@ -978,7 +981,7 @@ func (host *dotnetLanguageHost) RunPlugin(
 	cmd.Dir = req.Pwd
 	cmd.Env = req.Env
 	cmd.Stdout, cmd.Stderr = stdout, stderr
-	if err := cmd.Run(); err != nil {
+	if err = cmd.Run(); err != nil {
 		if exiterr, ok := err.(*exec.ExitError); ok {
 			// If the program ran, but exited with a non-zero error code.  This will happen often, since user
 			// errors will trigger this.  So, the error message should look as nice as possible.