Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to specify resource options at the stack level #245

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Add ability to specify resource options at the stack level #245

merged 4 commits into from
Nov 25, 2024

Commits on Nov 25, 2024

  1. Add ability to specify resource options at the stack level 

    It has been possible to specify Pulumi resource options at the stack
level, but it did not flow through to the actual resources. This PR
makes sure that the inheritance works correctly.

This PR also adds functionality to automatically set the Stack
environment based on the App provider. Because the App creates the
stacks in an async context, we can use provider functions to lookup the
environment and then pass the resolved environment to the stack. This
means that all Stacks have their environment provided by default. This
will cut down on the number of Intrinsics used in the generated
template.

If the user provides a provider to the Stack we are no longer in an
async context which means we can't determine the environment from the
provider and fall back to an environment agnostic stack.

re #61, re #219
    @corymhall
    corymhall committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    4d2e85a View commit details
    Browse the repository at this point in the history

  2. updates

    @corymhall
    corymhall committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    0f7bdf7 View commit details
    Browse the repository at this point in the history

  3. updates based on review

    @corymhall
    corymhall committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    36044f8 View commit details
    Browse the repository at this point in the history

  4. update docs

    @corymhall
    corymhall committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    efd3750 View commit details
    Browse the repository at this point in the history