Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: test CI #2582

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/run-acceptance-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,24 @@ jobs:
$GITHUB_ENV
- name: Build SDK
run: make build_${{ matrix.language }}
# Commit all changed files back to the repository
# - name: Sync any changes from the remote
# run: git pull origin ${{ github.head_ref }}
- name: Commit generated SDK
uses: rquitales/git-recommit-action@v1
id: recommit
with:
commit_message: "[automated] Add generated SDKs for ${{ matrix.language }}."
file_pattern: sdk/
# push_options: --dry-run
- name: Comment PR if changes were made
if: steps.recommit.outputs.changes_detected == 'true'
uses: thollander/actions-comment-pull-request@v2
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
message: >
A new commit was added to this PR as part of the SDK build process.
SDKs were recommitted for ${{ matrix.language }}.
- name: Check worktree clean
run: ./ci-scripts/ci/check-worktree-is-clean
- name: Compress SDK folder
Expand Down
2 changes: 1 addition & 1 deletion provider/resources.go
Original file line number Diff line number Diff line change
Expand Up @@ -7002,7 +7002,7 @@ func Provider() tfbridge.ProviderInfo {
prov.SetAutonaming(255, "-")

// Add a CSharp-specific override for aws_s3_bucket.bucket.
prov.Resources["aws_s3_bucket_legacy"].Fields["bucket"].CSharpName = "BucketName"
prov.Resources["aws_s3_bucket_legacy"].Fields["bucket"].CSharpName = "BucketNameNew"

return prov
}
6 changes: 3 additions & 3 deletions sdk/dotnet/S3/Bucket.cs
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ public partial class Bucket : global::Pulumi.CustomResource
/// The name of the bucket. If omitted, this provider will assign a random, unique name. Must be lowercase and less than or equal to 63 characters in length. A full list of bucket naming rules [may be found here](https://docs.aws.amazon.com/AmazonS3/latest/userguide/bucketnamingrules.html).
/// </summary>
[Output("bucket")]
public Output<string> BucketName { get; private set; } = null!;
public Output<string> BucketNameNew { get; private set; } = null!;

/// <summary>
/// The bucket domain name. Will be of format `bucketname.s3.amazonaws.com`.
Expand Down Expand Up @@ -704,7 +704,7 @@ public sealed class BucketArgs : global::Pulumi.ResourceArgs
/// The name of the bucket. If omitted, this provider will assign a random, unique name. Must be lowercase and less than or equal to 63 characters in length. A full list of bucket naming rules [may be found here](https://docs.aws.amazon.com/AmazonS3/latest/userguide/bucketnamingrules.html).
/// </summary>
[Input("bucket")]
public Input<string>? BucketName { get; set; }
public Input<string>? BucketNameNew { get; set; }

/// <summary>
/// Creates a unique bucket name beginning with the specified prefix. Conflicts with `bucket`. Must be lowercase and less than or equal to 37 characters in length. A full list of bucket naming rules [may be found here](https://docs.aws.amazon.com/AmazonS3/latest/userguide/bucketnamingrules.html).
Expand Down Expand Up @@ -873,7 +873,7 @@ public sealed class BucketState : global::Pulumi.ResourceArgs
/// The name of the bucket. If omitted, this provider will assign a random, unique name. Must be lowercase and less than or equal to 63 characters in length. A full list of bucket naming rules [may be found here](https://docs.aws.amazon.com/AmazonS3/latest/userguide/bucketnamingrules.html).
/// </summary>
[Input("bucket")]
public Input<string>? BucketName { get; set; }
public Input<string>? BucketNameNew { get; set; }

/// <summary>
/// The bucket domain name. Will be of format `bucketname.s3.amazonaws.com`.
Expand Down