[PR #5983/6b8e291d backport][3.49] Future proof the pulp_file repair tests for python 3.11 #5987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
ggainey
approved these changes
Nov 7, 2024
gerrod3
force-pushed
the
patchback/backports/3.49/6b8e291d22d3bb61d42c4dbd7437951aa40d1f2b/pr-5983
branch
from
ee0dd92
to
3734fba
Compare
This change unblocks the functional pulp_file repair tests when run on a python 3.11+ environment. Stronger typing for the random.sample function is introduced in 3.11 and requires now a Sequence type as an input or it will throw a TypeError. see: https://docs.python.org/3.11/library/random.html#random.sample [noissue] (cherry picked from commit 6b8e291)
gerrod3
force-pushed
the
patchback/backports/3.49/6b8e291d22d3bb61d42c4dbd7437951aa40d1f2b/pr-5983
branch
from
3734fba
to
86db887
Compare
ggainey
deleted the
patchback/backports/3.49/6b8e291d22d3bb61d42c4dbd7437951aa40d1f2b/pr-5983
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #5983 as merged into main (6b8e291).
This change unblocks the functional pulp_file repair tests when run on a python 3.11+ environment. Stronger typing for the random.sample function is introduced in 3.11 and requires now a Sequence type as an input or it will throw a TypeError.
see: https://docs.python.org/3.11/library/random.html#random.sample
[noissue]