Sort nil dates last in both directions #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Container Scanning Status: ✅ Success |
hackartisan
force-pushed
the
272-nil-dates-last
branch
from
69467ec
to
755e697
Compare
tpendragon
requested changes
Nov 27, 2024
| @@ -114,6 +114,48 @@ defmodule DpulCollectionsWeb.SearchLiveTest do | |||
| |> Enum.empty?() | |||
| end | |||
|
|
|||
| test "when sorting by date, a nil date always sorts last", %{conn: conn} do | |||
| # {"id": "nildate", "title_txtm": "Document Nil Date"}, | |||
There was a problem hiding this comment.
Are these comments still useful to have?
| {:ok, view, html} = live(conn, "/search?sort_by=date_desc&page=11") | ||
| {:ok, document} = Floki.parse_document(html) | ||
|
|
||
| assert document |
There was a problem hiding this comment.
Suggestion: Can we use has_element? instead of Floki parsing the HTML? https://hexdocs.pm/phoenix_live_view/Phoenix.LiveViewTest.html#has_element?/3
hackartisan
force-pushed
the
272-nil-dates-last
branch
from
755e697
to
52532f9
Compare
|
@tpendragon thanks for the suggestions, it's updated |
tpendragon
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
companion PR: pulibrary/pul_solr#445
This will probably require a reindex (via
DpulCollections.IndexingPipeline.Figgy.IndexingConsumer.start_over!(n))advances #272