i2069: Add a new field for specific languages on the Show page #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
sandbergja
force-pushed
the
new-iso-language-field
branch
from
0677f2a
to
7fa73c3
Compare
christinach
previously approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Thank you @sandbergja 🍄 . Just one comment in traject_config.
As part of a new ticket can we add a document in the docs/ file describing the need and the logic of the language display field ? I'm thinking more of the meeting we had with the catalogers and the info they provided.
| @@ -727,6 +728,10 @@ | |||
| # 546 XX 3a | |||
| to_field 'language_display', extract_marc('5463a') | |||
|
|
|||
| to_field 'language_name_display' do |record, accumulator| | |||
There was a problem hiding this comment.
@sandbergja can you add a comment that this field will be used to show specific languages in the record page?
| end | ||
| let(:extractor) { described_class.new(LanguageService.new, MARC::Record.new_from_hash('fields' => fields)) } | ||
| it 'finds a language from the 008' do | ||
| expect(extractor.specific_names).to eq(['Modern Greek (1453-)']) |
sandbergja
force-pushed
the
new-iso-language-field
branch
from
ebd1fa8
to
c8e2a49
Compare
christinach
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new solr field,
language_name_display, which we could then add to the Show page.Part of #2069