Upgrade to Pug 3 #88
Upgrade to Pug 3 #88
Conversation
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
Coverage ? 100.00%
==========================================
Files ? 1
Lines ? 144
Branches ? 0
==========================================
Hits ? 144
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
|
@ForbesLindesay sorry to bug, is anyone looking at this repo at all? |
@borisovg Did the test report your changes as failing, or is the test actually broken? Did it break before you updated the dependencies & made the changes, or afterwards? Removing a test bc it's broken doesn't sound like a fix per se. Updating the pug-cli version is probably also needed for this change to automatically propagate, like #87 did. I've made PR to your update that updates the version & the changelog. |
|
@TimothyGu can you take a look at this? |
|
@Anduh the test was already failing before I made any changes and I didn’t see anything in the code specific to what that test was supposedly testing (rejecting UTF new lines) |
|
@borisovg I created the @anduh/pug-cli-package based on your update, so that there now exists an alternative package to this stagnant one. Are you interested in becoming a co-maintainer of it? I haven't set up the Codecov or Travis CI stuff yet, but will look into it, if the original pug-cli doesn't get any attention by the authors. I changed it's command to |
|
Is there any feedback left to address or can this PR be merged? |
To fix pugjs/pug#3312 Old original `pug-cli` depends on `[email protected]`. `@anduh/pug-cli` is the fork to fix this problem. ref. pugjs/pug-cli#88 (comment)
…#4 from tokilabs/merging-forks) Here's a list of the merged contributions: - @Anduh at [anduh/pug-cli](https://github.com/anduh/pug-cli) - Update Pug to version 3.0.2 (Closes pugjs#88) - @anthony-tron at [anthony-tron/pug-cli](https://github.com/anthony-tron/pug-cli) - Hot reload of options file and YAML in `-O | --obj` option (Closes pugjs#89) - @lazdmx at https://github.com/lazdmx/pug-cli - Allow symlink as input 2d6c334 (Closes pugjs#80) [2d6c334](lazdmx@2d6c334) - @funai at [funai/pug-cli](https://github.com/funai/pug-cli) - [Allow templates to use YAML front-matter](4d5b6e6) - [Inject `extends` from frontmatter `layout`](4d5b6e6#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346R260)
closes #86