Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UUID changes #58

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

UUID changes #58

wants to merge 4 commits into from

Conversation

crimsonred
Copy link
Contributor

@crimsonred crimsonred commented Jan 4, 2022

refactor(uuid): BREAKING CHANGES, UUID is not automatically generated by the SDK anymore. If NOT set an exception will be thrown.

UUID is not automatically generated by the SDK anymore. Please set it in the PNConfig before instantiating the PubNub object. If UUID is empty an exception will be thrown.

BREAKING CHANGES: UUID is not automatically generated by the SDK anymore. If NOT set an exception will be thrown.

budgetpreneur
budgetpreneur previously approved these changes Jan 5, 2022
Copy link
Contributor

@budgetpreneur budgetpreneur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

budgetpreneur
budgetpreneur previously approved these changes Jan 6, 2022
Copy link
Contributor

@budgetpreneur budgetpreneur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crimsonred
Copy link
Contributor Author

@client-engineering-bot release

Use PAT instead of GitHub context-provided `token` for checkouts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants