Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced flag for enabling Event Engine #149

Closed

Conversation

jguz-pubnub
Copy link
Contributor

@jguz-pubnub jguz-pubnub commented Oct 31, 2023

  1. Removed associated types from connection statuses in order not to introduce more breaking changes
    • What's been added is connectionError case only
  2. Added enableEventEngine flag in PubNubConfiguration and ee query parameter
    • This query parameter is added for subscribe, heartbeat, and leave calls assuming that the enableEventEngine flag is set to true
  3. SubscriptionSession and SubscribeSessionFactory are being deprecated
    • These classes are marked as public, so customers can subscribe/unsubscribe without using PubNub client. This should be prohibited and obsoleted with a major upgrade
  4. Added strategy pattern to switch between old and new implementation for the Subscribe loop
    • This is temporary and should be removed if we decide to get rid of enableEventEngine flag and always use EE
  5. Reusing existing unit tests in SubscribeRouterTests to test old & new implementations

@jguz-pubnub jguz-pubnub requested a review from parfeon as a code owner October 31, 2023 16:39
@jguz-pubnub jguz-pubnub deleted the feat/event-engine-presence-contract-tests branch November 27, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant