Fix excessive memory usage in the high-volume messages use case

pubnub · Dec 10, 2024 · f1b575c · f1b575c
1 parent 4ff9421
commit f1b575c
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 10 deletions.
diff --git a/Sources/PubNub/Extensions/URLSessionConfiguration+PubNub.swift b/Sources/PubNub/Extensions/URLSessionConfiguration+PubNub.swift
@@ -50,6 +50,8 @@ public extension URLSessionConfiguration {
     let configuration = URLSessionConfiguration.pubnub
     configuration.timeoutIntervalForRequest += Constant.minimumSubscribeRequestTimeout
     configuration.httpMaximumConnectionsPerHost = 1
+    configuration.requestCachePolicy = .reloadIgnoringLocalCacheData
+    configuration.urlCache = nil
 
     return configuration
   }

diff --git a/Sources/PubNub/Models/PubNubFile.swift b/Sources/PubNub/Models/PubNubFile.swift
@@ -305,6 +305,8 @@ public protocol PubNubFileEvent {
   var additionalMessage: JSONCodable? { get }
   /// Meta information for the event
   var metadata: JSONCodable? { get }
+  /// A user-provided custom message type
+  var customMessageType: String? { get set }
 
   /// Allows for converting  between different `PubNubFileEvent` types
   init(from other: PubNubFileEvent) throws
@@ -339,46 +341,51 @@ public struct PubNubFileEventBase: PubNubFileEvent, Hashable {
   public var channelGroup: String?
   public var publisher: String
   public var timetoken: Timetoken
+  public var customMessageType: String?
 
-  var concreteFile: PubNubFileBase
   public var file: PubNubFile {
-    return concreteFile
+    concreteFile
   }
 
-  var concreteAdditionalMessage: AnyJSON?
   public var additionalMessage: JSONCodable? {
     get {
-      return concreteAdditionalMessage
+      concreteAdditionalMessage
     }
     set {
       concreteAdditionalMessage = newValue?.codableValue
     }
   }
-
-  var concreteMeta: AnyJSON?
+
   public var metadata: JSONCodable? {
     get {
-      return concreteMeta
+      concreteMeta
     }
     set {
       concreteMeta = newValue?.codableValue
     }
   }
 
+  var concreteFile: PubNubFileBase
+  var concreteAdditionalMessage: AnyJSON?
+  var concreteMeta: AnyJSON?
+
+
   public init(
     file: PubNubFile,
     channelGroup: String?,
     publisher: String,
     timetoken: Timetoken,
     additionalMessage: JSONCodable?,
-    metadata: JSONCodable?
+    metadata: JSONCodable?,
+    customMessageType: String? = nil
   ) {
     concreteFile = PubNubFileBase(from: file)
     self.channelGroup = channelGroup
     self.publisher = publisher
     self.timetoken = timetoken
     self.additionalMessage = additionalMessage
     self.metadata = metadata
+    self.customMessageType = customMessageType
   }
 
   public init(from other: PubNubFileEvent) throws {
@@ -388,7 +395,8 @@ public struct PubNubFileEventBase: PubNubFileEvent, Hashable {
       publisher: other.publisher,
       timetoken: other.timetoken,
       additionalMessage: other.additionalMessage,
-      metadata: other.metadata
+      metadata: other.metadata,
+      customMessageType: other.customMessageType
     )
   }
 
@@ -414,7 +422,8 @@ public struct PubNubFileEventBase: PubNubFileEvent, Hashable {
       publisher: publisher,
       timetoken: subscription.publishTimetoken.timetoken,
       additionalMessage: filePayload.additionalDetails,
-      metadata: subscription.metadata
+      metadata: subscription.metadata,
+      customMessageType: subscription.customMessageType
     )
   }