Fixing unit tests for Subscribe Effects and DelayedHeartbeatEffect

pubnub · Feb 22, 2024 · 2f04aaf · 2f04aaf
1 parent d5c5083
commit 2f04aaf
Show file tree

Hide file tree

Showing 2 changed files with 313 additions and 248 deletions.
diff --git a/Tests/PubNubTests/EventEngine/Presence/DelayedHeartbeatEffectTests.swift b/Tests/PubNubTests/EventEngine/Presence/DelayedHeartbeatEffectTests.swift
@@ -28,9 +28,10 @@ class DelayedHeartbeatEffectTests: XCTestCase {
   }
 
   override func tearDown() {
-    mockUrlSession = nil
     delegate = nil
+    mockUrlSession = nil
     httpSession = nil
+    factory = nil
     super.tearDown()
   }
 
@@ -43,7 +44,7 @@ class DelayedHeartbeatEffectTests: XCTestCase {
 
     let delayRange = 2.0...3.0
     let automaticRetry = AutomaticRetry(retryLimit: 3, policy: .linear(delay: delayRange.lowerBound), excluded: [])
-    let effect = configureEffect(attempt: 0, automaticRetry: automaticRetry, error: PubNubError(.unknown))
+    let effect = configureEffectToTest(retryAttempt: 0, automaticRetry: automaticRetry, dueTo: PubNubError(.unknown))
     let startDate = Date()
 
     effect.performTask { returnedEvents in
@@ -65,7 +66,7 @@ class DelayedHeartbeatEffectTests: XCTestCase {
     let delayRange = 2.0...3.0
     let automaticRetry = AutomaticRetry(retryLimit: 3, policy: .linear(delay: delayRange.lowerBound), excluded: [])
     let error = PubNubError(.unknown)
-    let effect = configureEffect(attempt: 0, automaticRetry: automaticRetry, error: error)
+    let effect = configureEffectToTest(retryAttempt: 0, automaticRetry: automaticRetry, dueTo: error)
 
     effect.performTask { returnedEvents in
       let expectedError = PubNubError(.internalServiceError)
@@ -84,7 +85,7 @@ class DelayedHeartbeatEffectTests: XCTestCase {
 
     let automaticRetry = AutomaticRetry(retryLimit: 3, policy: .linear(delay: 2.0), excluded: [])
     let error = PubNubError(.unknown)
-    let effect = configureEffect(attempt: 3, automaticRetry: automaticRetry, error: error)
+    let effect = configureEffectToTest(retryAttempt: 3, automaticRetry: automaticRetry, dueTo: error)
 
     mockResponse(GenericServicePayloadResponse(status: 200))
 
@@ -108,9 +109,10 @@ fileprivate extension DelayedHeartbeatEffectTests {
     }
   }
 
-  func configureEffect(
-    attempt: Int, automaticRetry: AutomaticRetry?,
-    error: PubNubError
+  func configureEffectToTest(
+    retryAttempt attempt: Int,
+    automaticRetry: AutomaticRetry?,
+    dueTo error: PubNubError
   ) -> any EffectHandler<Presence.Event> {
     factory.effect(
       for: .delayedHeartbeat(