Expoential as a default reconnection policy #196
Conversation
seba-aln
force-pushed
the
feat/exponential-reconnect-by-default
branch
from
42b26a3 to
b9db664
Compare
| @@ -89,6 +93,26 @@ def _stop_heartbeat_timer(self): | |||
| self._timer = None | |||
|
|
|||
|
|
|||
| class LinearDelay: | |||
There was a problem hiding this comment.
Is it possible to provide custom delay other than 2?
There was a problem hiding this comment.
No, not really. Should we add this option?
There was a problem hiding this comment.
added in latest commit. thanks for pointing that out ;)
| @@ -101,6 +101,13 @@ def __init__(self, pubnub): | |||
| def _register_heartbeat_timer(self): | |||
| self.stop_heartbeat_timer() | |||
|
|
|||
| if self._retry_limit_reached(): | |||
There was a problem hiding this comment.
I don't know how it works in Python, but should announcing disconnected status being part of EE?
There was a problem hiding this comment.
No. This one is for non-event engine subscribe (yeah, python has more than one subscribe)
| context.pubnub.subscribe().channels('foo').execute() | ||
|
|
||
|
|
||
| @when('I subscribe with timetoken {timetoken}') | ||
| def step_impl(context: PNContext, timetoken: str): # noqa F811 | ||
| @async_run_until_complete | ||
| async def step_impl(context: PNContext, timetoken: str): # noqa F811 |
There was a problem hiding this comment.
I'm curious, what it means? # noqa F811
There was a problem hiding this comment.
it disables validation errors upon redeclaration of method. in this file there are more methods called step_impl, but they are the content of a @when decorator. so TL:DR - 'tis just for linter
seba-aln
force-pushed
the
feat/exponential-reconnect-by-default
branch
2 times, most recently
from
bcc837f to
b6746db
Compare
No description provided.