Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space and MessageType for publish and signal #76

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Space and MessageType for publish and signal #76

wants to merge 8 commits into from

Conversation

seba-aln
Copy link
Contributor

No description provided.

marcin-cebo
marcin-cebo requested changes Jan 24, 2023
View reviewed changes
src/PubNub/Endpoints/PubSub/Publish.php Outdated Show resolved Hide resolved
src/PubNub/Endpoints/PubSub/Signal.php Show resolved Hide resolved
src/PubNub/Endpoints/PubSub/Publish.php Show resolved Hide resolved
@seba-aln seba-aln force-pushed the feature/add-space-id-and-message-type branch from 7a2293d to 570b5e8 Compare February 7, 2023 14:58
@seba-aln seba-aln marked this pull request as draft February 7, 2023 14:59
@seba-aln seba-aln force-pushed the feature/add-space-id-and-message-type branch 4 times, most recently from a8ddd9b to 3bc41f4 Compare March 14, 2023 09:50
@seba-aln seba-aln marked this pull request as ready for review March 14, 2023 09:56
@seba-aln seba-aln force-pushed the feature/add-space-id-and-message-type branch from 3bc41f4 to debe66c Compare March 14, 2023 09:57
@seba-aln seba-aln requested a review from marcin-cebo March 14, 2023 09:57
MikeDobrzan
MikeDobrzan approved these changes Mar 14, 2023
View reviewed changes
Copy link

@MikeDobrzan MikeDobrzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have done a good dyd

marcin-cebo
marcin-cebo approved these changes Mar 14, 2023
View reviewed changes
Copy link

@marcin-cebo marcin-cebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

One comment:
maybe I missed that but I think it would be valuable to have integration test(tests that calls real server) that verify that SpaceId and MessageType functionality works for each functionality: publish/subscribe, file, history, signal.

src/PubNub/Models/Consumer/PNMessageType.php Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcin-cebo marcin-cebo marcin-cebo approved these changes

@mohitpubnub mohitpubnub Awaiting requested review from mohitpubnub

@MikeDobrzan MikeDobrzan Awaiting requested review from MikeDobrzan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seba-aln @marcin-cebo @MikeDobrzan