Support for file operations #103
Conversation
seba-aln
force-pushed
the
feat/files-endpoint
branch
from
e8b13f2 to
4d4d66a
Compare
seba-aln
force-pushed
the
feat/files-endpoint
branch
from
4d4d66a to
922b768
Compare
examples/FileSharing.php
Outdated
|
|
||
| // Listing files in the channel | ||
| $channelFiles = $pubnub->listFiles()->channel($channelName)->sync(); | ||
| if ($channelFiles->getCount() > 0) { |
There was a problem hiding this comment.
What do you think about introducing:
$fileCount = $channelFiles->getCount();
?
There was a problem hiding this comment.
would improve readability
| public function encryptMessage($message) | ||
| { | ||
| $crypto = $this->pubnub->getCryptoSafe(); | ||
| $message = PubNubUtil::writeValueAsString($message); |
There was a problem hiding this comment.
What do you think about renaming to:
$messageString
?
|
|
||
| protected function buildMessage() | ||
| { | ||
| $message = [ |
There was a problem hiding this comment.
Wouldn't $messageData be a more descriptive name?
| { | ||
| $params = []; | ||
| foreach ($this->customParamMapping as $customParam => $requestParam) { | ||
| if (isset($this->$customParam) && !empty($this->$customParam)) { |
There was a problem hiding this comment.
Is issset required here? What is a responsibility of empty method check?
There was a problem hiding this comment.
isset is a safeguard for accessing unintialized typed property and !empty checks if the value is not empty (not null, 0 or empty string
There was a problem hiding this comment.
ok, I thought that empty implicitly performs isset
because:
"The isset function only checks if a variable is set and not NULL"
| ->fileId($this->fileUploadEnvelope->getFileId()) | ||
| ->fileName($this->fileName); | ||
|
|
||
| if (isset($this->meta)) { |
There was a problem hiding this comment.
This line is duplicated in line 269, 272, 275 is this intentional?
There was a problem hiding this comment.
unintentional copypaste
seba-aln
force-pushed
the
feat/files-endpoint
branch
from
1fb3ba8 to
43c51a1
Compare
| { | ||
| $params = []; | ||
| foreach ($this->customParamMapping as $customParam => $requestParam) { | ||
| if (isset($this->$customParam) && !empty($this->$customParam)) { |
There was a problem hiding this comment.
ok, I thought that empty implicitly performs isset
because:
"The isset function only checks if a variable is set and not NULL"
|
@pubnub-release-bot release |
pubnub-release-bot
requested review from
techwritermat and
kazydek
as code owners
|
🚀 Release successfully completed 🚀 |
feat: Added support for file sharing operations