FCM sends GCM as a type parameter

pubnub · Jun 11, 2024 · ea00ed5 · ea00ed5
1 parent d3d7729
commit ea00ed5
Show file tree

Hide file tree

Showing 9 changed files with 13 additions and 14 deletions.
diff --git a/src/PubNub/Endpoints/Push/AddChannelsToPush.php b/src/PubNub/Endpoints/Push/AddChannelsToPush.php
@@ -48,8 +48,7 @@ protected function customParams()
         ];
 
         if ($this->pushType != PNPushType::APNS2) {
-            // v1 push -> add type
-            $params['type'] = $this->pushType;
+            $params['type'] = $this->getPushType();
         } else {
             // apns2 push -> add topic and environment
             $params['topic'] = $this->topic;

diff --git a/src/PubNub/Endpoints/Push/ListPushProvisions.php b/src/PubNub/Endpoints/Push/ListPushProvisions.php
@@ -5,7 +5,6 @@
 use PubNub\Enums\PNHttpMethod;
 use PubNub\Enums\PNOperationType;
 use PubNub\Enums\PNPushType;
-use PubNub\Exceptions\PubNubValidationException;
 use PubNub\Models\Consumer\Push\PNPushListProvisionsResult;
 
 class ListPushProvisions extends PushEndpoint
@@ -23,8 +22,7 @@ protected function customParams()
         $params = [];
 
         if ($this->pushType != PNPushType::APNS2) {
-            // v1 push -> add type
-            $params['type'] = $this->pushType;
+            $params['type'] = $this->getPushType();
         } else {
             // apns2 push -> add topic and environment
             $params['topic'] = $this->topic;

diff --git a/src/PubNub/Endpoints/Push/PushEndpoint.php b/src/PubNub/Endpoints/Push/PushEndpoint.php
@@ -146,4 +146,9 @@ protected function getName()
     {
         return static::OPERATION_NAME;
     }
+
+    protected function getPushType(): string
+    {
+        return $this->pushType == PNPushType::FCM ? 'gcm' : $this->pushType;
+    }
 }
diff --git a/src/PubNub/Endpoints/Push/RemoveChannelsFromPush.php b/src/PubNub/Endpoints/Push/RemoveChannelsFromPush.php
@@ -57,8 +57,7 @@ protected function customParams()
         ];
 
         if ($this->pushType != PNPushType::APNS2) {
-            // v1 push -> add type
-            $params['type'] = $this->pushType;
+            $params['type'] = $this->getPushType();
         } else {
             // apns2 push -> add topic and environment
             $params['topic'] = $this->topic;

diff --git a/src/PubNub/Endpoints/Push/RemoveDeviceFromPush.php b/src/PubNub/Endpoints/Push/RemoveDeviceFromPush.php
@@ -6,7 +6,6 @@
 use PubNub\Enums\PNHttpMethod;
 use PubNub\Enums\PNOperationType;
 use PubNub\Enums\PNPushType;
-use PubNub\Exceptions\PubNubValidationException;
 use PubNub\Models\Consumer\Push\PNPushRemoveAllChannelsResult;
 
 class RemoveDeviceFromPush extends PushEndpoint
@@ -24,8 +23,7 @@ protected function customParams()
         $params = [];
 
         if ($this->pushType != PNPushType::APNS2) {
-            // v1 push -> add type
-            $params['type'] = $this->pushType;
+            $params['type'] = $this->getPushType();
         } else {
             // apns2 push -> add topic and environment
             $params['topic'] = $this->topic;

diff --git a/tests/integrational/push/AddChannelsToPushEndpointTest.php b/tests/integrational/push/AddChannelsToPushEndpointTest.php
@@ -92,7 +92,7 @@ public function testPushAddFCM()
             ->withQuery([
                 "pnsdk" => $this->encodedSdkName,
                 "add" => "ch1,ch2,ch3",
-                "type" => "fcm",
+                "type" => "gcm",
                 "uuid" => "sampleUUID",
             ])
             ->setResponseBody('[1, "Modified Channels"]');

diff --git a/tests/integrational/push/ListPushProvisionsEndpointTest.php b/tests/integrational/push/ListPushProvisionsEndpointTest.php
@@ -64,7 +64,7 @@ public function testListChannelGroupFCM()
         $list->stubFor("/v1/push/sub-key/demo/devices/coolDevice")
             ->withQuery([
                 "pnsdk" => $this->encodedSdkName,
-                "type" => "fcm",
+                "type" => "gcm",
                 "uuid" => "sampleUUID",
             ])
             ->setResponseBody('[1, "Modified Channels"]');

diff --git a/tests/integrational/push/RemoveChannelsFromPushEndpointTest.php b/tests/integrational/push/RemoveChannelsFromPushEndpointTest.php
@@ -88,7 +88,7 @@ public function testPushRemoveFCM()
         $remove->stubFor("/v1/push/sub-key/demo/devices/coolDevice")
             ->withQuery([
                 "pnsdk" => $this->encodedSdkName,
-                "type" => "fcm",
+                "type" => "gcm",
                 "uuid" => "sampleUUID",
                 "remove" => "ch1,ch2,ch3"
             ])

diff --git a/tests/integrational/push/RemoveDeviceFromPushEndpointTest.php b/tests/integrational/push/RemoveDeviceFromPushEndpointTest.php
@@ -84,7 +84,7 @@ public function testRemovePushFCM()
         $remove->stubFor("/v1/push/sub-key/demo/devices/coolDevice/remove")
             ->withQuery([
                 "pnsdk" => $this->encodedSdkName,
-                "type" => "fcm",
+                "type" => "gcm",
                 "uuid" => "sampleUUID",
             ])
             ->setResponseBody('[1, "Modified Channels"]');