Skip to content

Commit

Permalink
Internal fixes (Apple platforms) (#324)
Browse files Browse the repository at this point in the history
fix(custom-field): fix for initializing `KMPAnyJSON` instance
fix(pubnub): add missing `filter` parameter for `getChannelMembers` method
  • Loading branch information
jguz-pubnub authored Dec 16, 2024
1 parent 23d303a commit 64fe45f
Show file tree
Hide file tree
Showing 11 changed files with 24 additions and 12 deletions.
13 changes: 9 additions & 4 deletions .pubnub.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
name: kotlin
version: 10.3.1
version: 10.3.2
schema: 1
scm: github.com/pubnub/kotlin
files:
- build/libs/pubnub-kotlin-10.3.1-all.jar
- build/libs/pubnub-kotlin-10.3.2-all.jar
sdks:
-
type: library
Expand All @@ -23,8 +23,8 @@ sdks:
-
distribution-type: library
distribution-repository: maven
package-name: pubnub-kotlin-10.3.1
location: https://repo.maven.apache.org/maven2/com/pubnub/pubnub-kotlin/10.3.1/pubnub-kotlin-10.3.1.jar
package-name: pubnub-kotlin-10.3.2
location: https://repo.maven.apache.org/maven2/com/pubnub/pubnub-kotlin/10.3.2/pubnub-kotlin-10.3.2.jar
supported-platforms:
supported-operating-systems:
Android:
Expand Down Expand Up @@ -121,6 +121,11 @@ sdks:
license-url: https://www.apache.org/licenses/LICENSE-2.0.txt
is-required: Required
changelog:
- date: 2024-12-16
version: v10.3.2
changes:
- type: improvement
text: "Internal fixes."
- date: 2024-12-12
version: v10.3.1
changes:
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## v10.3.2
December 16 2024

#### Modified
- Internal fixes.

## v10.3.1
December 12 2024

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ You will need the publish and subscribe keys to authenticate your app. Get your
<dependency>
<groupId>com.pubnub</groupId>
<artifactId>pubnub-kotlin</artifactId>
<version>10.3.1</version>
<version>10.3.2</version>
</dependency>
```

Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ RELEASE_SIGNING_ENABLED=true
SONATYPE_HOST=DEFAULT
SONATYPE_AUTOMATIC_RELEASE=false
GROUP=com.pubnub
VERSION_NAME=10.3.1
VERSION_NAME=10.3.2
POM_PACKAGING=jar

POM_NAME=PubNub SDK
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -756,6 +756,7 @@ class PubNubImpl(private val pubNubObjC: KMPPubNub) : PubNub {
channel = channel,
limit = limit,
page = page,
filter = filter,
sort = sort,
include = MemberInclude(
includeTotalCount = includeCount,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class SetChannelMetadataImpl(
metadataId = metadataId,
name = name,
description = description,
custom = KMPAnyJSON(value = custom?.value),
custom = KMPAnyJSON(custom),
includeCustom = includeCustom,
type = type,
status = status,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class SetChannelMembersImpl(
override fun async(callback: Consumer<Result<PNMemberArrayResult>>) {
pubnub.setChannelMembersWithChannel(
channel = channelId,
users = users.map { KMPUserMetadata(id = it.uuid, custom = KMPAnyJSON(it.custom?.value), status = it.status) },
users = users.map { KMPUserMetadata(id = it.uuid, custom = KMPAnyJSON(it.custom), status = it.status) },
limit = limit?.let { NSNumber(it) },
page = createPubNubHashedPage(from = page),
filter = filter,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class AddMembershipsImpl(
) : ManageMemberships {
override fun async(callback: Consumer<Result<PNChannelMembershipArrayResult>>) {
pubnub.setMembershipsWithChannels(
channels = channels.map { KMPChannelMetadata(it.channel, KMPAnyJSON(it.custom?.value), it.status) },
channels = channels.map { KMPChannelMetadata(it.channel, KMPAnyJSON(it.custom), it.status) },
userId = userId,
limit = limit?.let { NSNumber(it) },
page = createPubNubHashedPage(from = page),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class SetUUIDMetadataImpl(
externalId = externalId,
profileUrl = profileUrl,
email = email,
custom = KMPAnyJSON(value = custom?.value),
custom = KMPAnyJSON(custom),
includeCustom = includeCustom,
type = type,
status = status,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class SetStateImpl(
pubnub.setPresenceStateWithChannels(
channels = channels,
channelGroups = channelGroups,
state = KMPAnyJSON(value = state),
state = KMPAnyJSON(state),
onSuccess = callback.onSuccessHandler { PNSetStateResult(state = JsonElementImpl(it)) },
onFailure = callback.onFailureHandler()
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class PubNubImplTest : BaseTest() {
fun getVersionAndTimeStamp() {
val version = PubNubImpl.SDK_VERSION
val timeStamp = PubNubImpl.timestamp()
assertEquals("10.3.1", version)
assertEquals("10.3.2", version)
assertTrue(timeStamp > 0)
}

Expand Down

0 comments on commit 64fe45f

Please sign in to comment.