CI build fixes

.github/workflows/commands-handler.yml

@@ -27,6 +27,7 @@ jobs:
         uses: actions/checkout@v4
         with:
           token: ${{ secrets.GH_TOKEN }}
+          submodules: recursive
       - name: Checkout release actions
         if: steps.user-check.outputs.expected-user == 'true'
         uses: actions/checkout@v4

.github/workflows/release.yml

@@ -38,6 +38,7 @@ jobs:
         with:
           # This should be the same as the one specified for on.pull_request.branches
           ref: master
+          submodules: recursive
       - name: Checkout actions
         uses: actions/checkout@v4
         with:

.github/workflows/release/chat-maven-build.sh

@@ -1,2 +1,2 @@
 echo "Build Chat SDK module artifacts"
-./gradlew jar --no-configuration-cache
+./gradlew jar

.github/workflows/release/chat-maven-publish.sh

@@ -1 +1 @@
-./gradlew publishToSonatype closeSonatypeStagingRepository --no-configuration-cache
+./gradlew publishToSonatype closeSonatypeStagingRepository

.github/workflows/release/pre-github-pages-publish.sh

@@ -1 +1 @@
-./gradlew :dokkaGfmMultiModule --no-configuration-cache
+./gradlew :dokkaGfmMultiModule

.github/workflows/run-tests.yml

@@ -35,7 +35,7 @@ jobs:
           ./gradlew check
         env:
           SDK_PUB_KEY: ${{ secrets.SDK_PUB_KEY }}
-          SDK_SUB_KEY: ${{ secrets.SDK_PUB_KEY }}
+          SDK_SUB_KEY: ${{ secrets.SDK_SUB_KEY }}
           SDK_PAM_SUB_KEY: ${{ secrets.SDK_PAM_SUB_KEY }}
           SDK_PAM_PUB_KEY: ${{ secrets.SDK_PAM_PUB_KEY }}
           SDK_PAM_SEC_KEY: ${{ secrets.SDK_PAM_SEC_KEY }}

.github/workflows/run-validations.yml

@@ -53,7 +53,7 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-gradle-
       - name: Validate clean build
-        run: ./gradlew apiCheck ktlintFormat publishAllPublicationsToRepoRepository
+        run: ./gradlew apiCheck ktlintFormat publishAllPublicationsToRepoRepository -PRELEASE_SIGNING_ENABLED=false
       - name: Cancel workflow runs for commit on error
         if: failure()
         uses: ./.github/.release/actions/actions/utils/fast-jobs-failure

gradle.properties

@@ -1,6 +1,6 @@
 kotlin.code.style=official
-org.gradle.configuration-cache=true
 org.gradle.caching=true
+org.gradle.parallel=true
 kotlin.mpp.applyDefaultHierarchyTemplate=false
 
 org.gradle.jvmargs=-Xmx8g -XX:MaxMetaspaceSize=1g -XX:+HeapDumpOnOutOfMemoryError -Dfile.encoding=UTF-8

pubnub-chat-impl/src/commonTest/kotlin/com/pubnub/integration/BaseChatIntegrationTest.kt

@@ -95,7 +95,7 @@ abstract class BaseChatIntegrationTest : BaseIntegrationTest() {
     }
 
     @AfterTest
-    fun afterTest() = runTest(timeout = defaultTimeout) {
+    fun afterTest() = runTest {
         pubnub.removeUUIDMetadata(someUser.id).await()
         pubnub.removeUUIDMetadata(userPam.id).await()
         pubnub.removeChannelMetadata(channel01.id).await()

pubnub-chat-impl/src/commonTest/kotlin/com/pubnub/integration/ChannelIntegrationTest.kt

@@ -22,7 +22,7 @@ import kotlin.time.Duration.Companion.seconds
 
 class ChannelIntegrationTest : BaseChatIntegrationTest() {
     @Test
-    fun join() = runTest(timeout = defaultTimeout) {
+    fun join() = runTest {
         val channel = chat.createChannel(randomString()).await()
 
         val result = channel.join {}.await()
@@ -32,31 +32,31 @@ class ChannelIntegrationTest : BaseChatIntegrationTest() {
     }
 
     @Test
-    fun join_receivesMessages() = runTest(timeout = defaultTimeout) {
+    fun join_receivesMessages() = runTest {
     }
 
     @Test
-    fun join_close_disconnects() = runTest(timeout = defaultTimeout) {
+    fun join_close_disconnects() = runTest {
     }
 
     @Test
-    fun join_updates_lastReadMessageTimetoken() = runTest(timeout = defaultTimeout) {
+    fun join_updates_lastReadMessageTimetoken() = runTest {
     }
 
     @Test
-    fun connect() = runTest(timeout = defaultTimeout) {
+    fun connect() = runTest {
     }
 
     @Test
-    fun connect_receivesMessages() = runTest(timeout = defaultTimeout) {
+    fun connect_receivesMessages() = runTest {
     }
 
     @Test
-    fun connect_close_disconnects() = runTest(timeout = defaultTimeout) {
+    fun connect_close_disconnects() = runTest {
     }
 
     @Test
-    fun getUserRestrictions() = runTest(timeout = defaultTimeout) {
+    fun getUserRestrictions() = runTest {
         val userId = "userId"
         val user = UserImpl(chat = chatPam, id = userId)
         val ban = true
@@ -74,7 +74,7 @@ class ChannelIntegrationTest : BaseChatIntegrationTest() {
     }
 
     @Test
-    fun getUsersRestrictions() = runTest(timeout = defaultTimeout) {
+    fun getUsersRestrictions() = runTest {
         val userId01 = "userId01"
         val userId02 = "userId02"
         val ban = true
@@ -108,13 +108,13 @@ class ChannelIntegrationTest : BaseChatIntegrationTest() {
     }
 
     @Test
-    fun shouldReturnNoUserSuggestions_whenNoDatInCacheAndNoChannelsInChat() = runTest(timeout = defaultTimeout) {
+    fun shouldReturnNoUserSuggestions_whenNoDatInCacheAndNoChannelsInChat() = runTest {
         val userSuggestions = channel01.getUserSuggestions("sas@las").await()
         assertEquals(0, userSuggestions.size)
     }
 
     @Test
-    fun shouldReturnUserSuggestions_whenNoDataInCacheButUserAvailableInChat() = runTest(timeout = defaultTimeout) {
+    fun shouldReturnUserSuggestions_whenNoDataInCacheButUserAvailableInChat() = runTest {
         // given
         val userName = "userName_${someUser.id}"
         val user: User = chat.createUser(id = someUser.id, name = userName).await()
@@ -173,7 +173,7 @@ class ChannelIntegrationTest : BaseChatIntegrationTest() {
     }
 
     @Test
-    fun streamUpdatesOn() = runTest(timeout = defaultTimeout) {
+    fun streamUpdatesOn() = runTest {
         val newName = "newName"
         chat.createChannel(
             channel01.id,

pubnub-chat-impl/src/commonTest/kotlin/com/pubnub/integration/ChatIntegrationTest.kt

@@ -46,15 +46,15 @@ import kotlin.test.assertTrue
 
 class ChatIntegrationTest : BaseChatIntegrationTest() {
     @Test
-    fun createUser() = runTest(timeout = defaultTimeout) {
+    fun createUser() = runTest {
         val user = chat.createUser(someUser).await()
 
         assertEquals(someUser, user.asImpl().copy(updated = null, lastActiveTimestamp = null))
         assertNotNull(user.updated)
     }
 
     @Test
-    fun updateUser() = runTest(timeout = defaultTimeout) {
+    fun updateUser() = runTest {
         val user = chat.createUser(someUser).await()
         val expectedUser = user.asImpl().copy(
             name = randomString(),
@@ -84,7 +84,7 @@ class ChatIntegrationTest : BaseChatIntegrationTest() {
     }
 
     @Test
-    fun updateUser_doesntExist() = runTest(timeout = defaultTimeout) {
+    fun updateUser_doesntExist() = runTest {
         val e = assertFailsWith<PubNubException> {
             chat.updateUser(someUser.id, name = randomString()).await()
         }
@@ -94,7 +94,7 @@ class ChatIntegrationTest : BaseChatIntegrationTest() {
     }
 
     @Test
-    fun createDirectConversation() = runTest(timeout = defaultTimeout) {
+    fun createDirectConversation() = runTest {
         chat.initialize().await()
         // when
         val result = chat.createDirectConversation(someUser).await()
@@ -114,7 +114,7 @@ class ChatIntegrationTest : BaseChatIntegrationTest() {
     }
 
     @Test
-    fun createGroupConversation() = runTest(timeout = defaultTimeout) {
+    fun createGroupConversation() = runTest {
         val otherUsers = listOf(UserImpl(chat, randomString()), UserImpl(chat, randomString()))
 
         // when
@@ -138,7 +138,7 @@ class ChatIntegrationTest : BaseChatIntegrationTest() {
     }
 
     @Test
-    fun can_markAllMessagesAsRead() = runTest(timeout = defaultTimeout) {
+    fun can_markAllMessagesAsRead() = runTest {
         // create two membership for user one with "lastReadMessageTimetoken" and second without.
         val lastReadMessageTimetokenValue: Long = 17195737006492403
         val custom: CustomObject =
@@ -219,7 +219,7 @@ class ChatIntegrationTest : BaseChatIntegrationTest() {
 
     @Ignore // fails from time to time
     @Test
-    fun can_getUnreadMessagesCount_onMembership() = runTest(timeout = defaultTimeout) {
+    fun can_getUnreadMessagesCount_onMembership() = runTest {
         val channelId01 = channel01.id
 
         // send message
@@ -253,7 +253,7 @@ class ChatIntegrationTest : BaseChatIntegrationTest() {
 
     @Ignore // fails from time to time
     @Test
-    fun can_getUnreadMessageCounts_global() = runTest(timeout = defaultTimeout) {
+    fun can_getUnreadMessageCounts_global() = runTest {
         val channelId01 = channel01.id
         val channelId02 = channel02.id
 
@@ -302,14 +302,14 @@ class ChatIntegrationTest : BaseChatIntegrationTest() {
     }
 
     @Test
-    fun shouldReturnNoChannelSuggestions_whenNoDataInCacheAndNoChannelsInChat() = runTest(timeout = defaultTimeout) {
+    fun shouldReturnNoChannelSuggestions_whenNoDataInCacheAndNoChannelsInChat() = runTest {
         val channelSuggestions: Set<Channel> = chat.getChannelSuggestions("sas#las").await()
         assertEquals(0, channelSuggestions.size)
     }
 
     @Test
     fun shouldReturnChannelSuggestions_whenNoDataInCacheButChannelAvailableInChat() =
-        runTest(timeout = defaultTimeout) {
+        runTest {
             val channelName = "channelName_${channel01.id}"
             chat.createChannel(id = channel01.id, name = channelName).await()
 
@@ -321,13 +321,13 @@ class ChatIntegrationTest : BaseChatIntegrationTest() {
         }
 
     @Test
-    fun shouldReturnNoUserSuggestions_whenNoDatInCacheAndNoChannelsInChat() = runTest(timeout = defaultTimeout) {
+    fun shouldReturnNoUserSuggestions_whenNoDatInCacheAndNoChannelsInChat() = runTest {
         val userSuggestions = chat.getUserSuggestions("sas@las").await()
         assertEquals(0, userSuggestions.size)
     }
 
     @Test
-    fun shouldReturnUserSuggestions_whenNoDataInCacheButUserAvailableInChat() = runTest(timeout = defaultTimeout) {
+    fun shouldReturnUserSuggestions_whenNoDataInCacheButUserAvailableInChat() = runTest {
         val userName = "userName_${someUser.id}"
         chat.createUser(id = someUser.id, name = userName).await()
 
@@ -339,7 +339,7 @@ class ChatIntegrationTest : BaseChatIntegrationTest() {
     }
 
     @Test
-    fun register_unregister_list_pushNotificationOnChannel() = runTest(timeout = defaultTimeout) {
+    fun register_unregister_list_pushNotificationOnChannel() = runTest {
         // set up push config
         val chatConfig = ChatConfiguration(
             pushNotifications = PushNotificationsConfig(
@@ -385,7 +385,7 @@ class ChatIntegrationTest : BaseChatIntegrationTest() {
     }
 
     @Test
-    fun can_getEventsHistory() = runTest(timeout = defaultTimeout) {
+    fun can_getEventsHistory() = runTest {
         // given
         val channelId01 = channel01.id
         val userId = someUser.id

pubnub-chat-impl/src/commonTest/kotlin/com/pubnub/integration/MembershipIntegrationTest.kt

@@ -11,7 +11,7 @@ import kotlin.test.assertEquals
 
 class MembershipIntegrationTest : BaseChatIntegrationTest() {
     @Test
-    fun streamUpdatesOn() = runTest(timeout = defaultTimeout) {
+    fun streamUpdatesOn() = runTest {
         chat.createChannel(
             channel01.id,
             channel01.name,

pubnub-chat-impl/src/commonTest/kotlin/com/pubnub/integration/MessageIntegrationTest.kt

@@ -15,7 +15,7 @@ import kotlin.test.assertEquals
 
 class MessageIntegrationTest : BaseChatIntegrationTest() {
     @Test
-    fun streamUpdatesOn() = runTest(timeout = defaultTimeout) {
+    fun streamUpdatesOn() = runTest {
         chat.createChannel(
             channel01.id,
             channel01.name,

pubnub-chat-impl/src/commonTest/kotlin/com/pubnub/integration/UserIntegrationTest.kt

@@ -26,7 +26,7 @@ import kotlin.test.assertTrue
 
 class UserIntegrationTest : BaseChatIntegrationTest() {
     @Test
-    fun getChannelRestrictions() = runTest(timeout = defaultTimeout) {
+    fun getChannelRestrictions() = runTest {
         val channelId = "channelId01"
         val channel = ChannelImpl(chat = chatPam, id = channelId)
         val ban = true
@@ -44,7 +44,7 @@ class UserIntegrationTest : BaseChatIntegrationTest() {
     }
 
     @Test
-    fun getChannelsRestrictions_sortAsc() = runTest(timeout = defaultTimeout) {
+    fun getChannelsRestrictions_sortAsc() = runTest {
         val channelId01 = "channelId01"
         val channelId02 = "channelId02"
         val ban = true
@@ -84,7 +84,7 @@ class UserIntegrationTest : BaseChatIntegrationTest() {
     }
 
     @Test
-    fun getChannelsRestrictions_sortDsc() = runTest(timeout = defaultTimeout) {
+    fun getChannelsRestrictions_sortDsc() = runTest {
         val channelId01 = "channelId01"
         val channelId02 = "channelId02"
         val ban = true
@@ -117,7 +117,7 @@ class UserIntegrationTest : BaseChatIntegrationTest() {
     }
 
     @Test
-    fun streamUpdatesOn() = runTest(timeout = defaultTimeout) {
+    fun streamUpdatesOn() = runTest {
         val newName = "newName"
         val expectedUpdates = listOf(
             listOf(someUser),
@@ -148,7 +148,7 @@ class UserIntegrationTest : BaseChatIntegrationTest() {
     }
 
     @Test
-    fun calling_active_should_throw_exception_when_storeUserActivityTimestamps_is_false() = runTest(timeout = defaultTimeout) {
+    fun calling_active_should_throw_exception_when_storeUserActivityTimestamps_is_false() = runTest {
         val e = assertFailsWith<PubNubException> {
             someUser.active().await()
         }
@@ -160,7 +160,7 @@ class UserIntegrationTest : BaseChatIntegrationTest() {
     }
 
     @Test
-    fun whenUserDoesNotExist_init_should_create_it_with_lastActiveTimestamp() = runTest(timeout = defaultTimeout) {
+    fun whenUserDoesNotExist_init_should_create_it_with_lastActiveTimestamp() = runTest {
         // set up storeUserActivityTimestamps
         val chatConfig = ChatConfiguration(
             storeUserActivityTimestamps = true
@@ -176,7 +176,7 @@ class UserIntegrationTest : BaseChatIntegrationTest() {
     }
 
     @Test
-    fun whenUserExists_init_should_update_lastActiveTimestamp() = runTest(timeout = defaultTimeout) {
+    fun whenUserExists_init_should_update_lastActiveTimestamp() = runTest {
         // set up storeUserActivityTimestamps
         val chatConfig = ChatConfiguration(
             storeUserActivityTimestamps = true
@@ -196,7 +196,7 @@ class UserIntegrationTest : BaseChatIntegrationTest() {
     }
 
     @Test
-    fun adminCanSubscribeToInternalChannelAndGetReportedUserEvent() = runTest(timeout = defaultTimeout) {
+    fun adminCanSubscribeToInternalChannelAndGetReportedUserEvent() = runTest {
         val reason = "rude"
         val assertionErrorInListener01 = CompletableDeferred<AssertionError?>()
         val removeListenerAndUnsubscribe: AutoCloseable = chat.listenForEvents<EventContent.Report>(