Review feedback

pubnub · Dec 4, 2024 · 065ac72 · 065ac72
1 parent 75debe1
commit 065ac72
Show file tree

Hide file tree

Showing 7 changed files with 3 additions and 144 deletions.
diff --git a/.github/workflows/release/js-pre-npm-build.sh b/.github/workflows/release/js-pre-npm-build.sh
@@ -1,4 +1,4 @@
-echo "Build Chat SDK module artifacts"
+echo "Build JS Chat SDK module artifacts"
 pushd ..
 ./gradlew :jsNodeProductionLibraryDistribution
 ./gradlew :packJsPackage

diff --git a/.github/workflows/release/kotlin-maven-build.sh b/.github/workflows/release/kotlin-maven-build.sh
@@ -1,5 +1,5 @@
 set -e
-echo "Build Chat SDK module artifacts"
+echo "Build Kotlin and Swift Chat SDK module artifacts"
 ./gradlew -PENABLE_TARGET_IOS_ALL=true :podPublishReleaseXCFramework assemble
 find build/cocoapods/publish/release/PubNubChat.xcframework -exec touch -t 00000000 {} +
 rm -f build/cocoapods/publish/release/PubNubChat.xcframework.zip

diff --git a/.github/workflows/release/kotlin-pre-publish.sh b/.github/workflows/release/kotlin-pre-publish.sh
@@ -1,4 +1,5 @@
 set -e
+echo "Update Swift Chat SDK checksum in Package.swift"
 ./gradlew -PENABLE_TARGET_IOS_ALL=true :podPublishReleaseXCFramework
 find build/cocoapods/publish/release/PubNubChat.xcframework -exec touch -t 00000000 {} +
 rm -f build/cocoapods/publish/release/PubNubChat.xcframework.zip

diff --git a/build-logic/gradle-plugins/build.gradle.kts b/build-logic/gradle-plugins/build.gradle.kts
@@ -22,18 +22,6 @@ gradlePlugin {
             id = "pubnub.dokka"
             implementationClass = "com.pubnub.gradle.PubNubDokkaPlugin"
         }
-        register("pubnubInteg") {
-            id = "pubnub.integration-test"
-            implementationClass = "com.pubnub.gradle.PubNubIntegrationTestPlugin"
-        }
-        register("pubnubTest") {
-            id = "pubnub.test"
-            implementationClass = "com.pubnub.gradle.PubNubTestPlugin"
-        }
-        register("pubnubJavaLibrary") {
-            id = "pubnub.java-library"
-            implementationClass = "com.pubnub.gradle.PubNubJavaLibraryPlugin"
-        }
         register("pubnubKotlinLibrary") {
             id = "pubnub.kotlin-library"
             implementationClass = "com.pubnub.gradle.PubNubKotlinLibraryPlugin"

diff --git a/build-logic/gradle-plugins/src/main/kotlin/com/pubnub/gradle/PubNubIntegrationTestPlugin.kt b/build-logic/gradle-plugins/src/main/kotlin/com/pubnub/gradle/PubNubIntegrationTestPlugin.kt
diff --git a/build-logic/gradle-plugins/src/main/kotlin/com/pubnub/gradle/PubNubJavaLibraryPlugin.kt b/build-logic/gradle-plugins/src/main/kotlin/com/pubnub/gradle/PubNubJavaLibraryPlugin.kt
diff --git a/build-logic/gradle-plugins/src/main/kotlin/com/pubnub/gradle/PubNubTestPlugin.kt b/build-logic/gradle-plugins/src/main/kotlin/com/pubnub/gradle/PubNubTestPlugin.kt