Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PubnubUnity based on C# SDK codebase #68

Open
wants to merge 118 commits into
base: develop
Choose a base branch
from
Open

PubnubUnity based on C# SDK codebase #68

wants to merge 118 commits into from

Conversation

budgetpreneur
Copy link
Contributor

No description provided.

crimsonred
crimsonred suggested changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@crimsonred crimsonred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. When running the example, I subscribe (it subscribes) and then I publish (it publishes), but I don't see the message as a subscribe response (no logs in console or in the window)

  2. Not all integration tests pass

Screen Shot 2020-01-06 at 11 24 11 AM

  1. I don't see unit (Edit Mode) tests

budgetpreneur and others added 21 commits April 6, 2020 16:37
@budgetpreneur
Merge branch 'develop' into atce4096-unity
eadfdc5
@budgetpreneur
Merge branch 'develop' into atce4096-unity
68f39e6
@budgetpreneur
minor updates
73edac7
@budgetpreneur
Merge branch 'develop' into atce4096-unity
c5feb36
@budgetpreneur
hmacsha256 refactor
5a7d24e
@budgetpreneur
removed conditional directive
c275dc1
@budgetpreneur
Merge branch 'master' into atclen51
1a2df3b
@budgetpreneur
Removed Portable.BouncyCastle & code refactored for native .net library
74ac9d9
@budgetpreneur
minor update to tests
1e7f8a0
@budgetpreneur
minor update to tests
00cb7da
@budgetpreneur
feature file update
9cd483a
@budgetpreneur
try catch for publish
52bda2f
@budgetpreneur
capture PNStatus from UrlProcessRequest
169775d
@budgetpreneur
no resubscribe on access denied
3ff11b7
@budgetpreneur
refactor to stop subscribe on 403
0a39378
@budgetpreneur
example update
3a1030b
@budgetpreneur
Revert "example update"
246d50c 
This reverts commit 3a1030b.
@budgetpreneur
example update
791d0b0
@budgetpreneur
Merge branch 'atclen94' into atce4096-unity
cb0d15b
@budgetpreneur
Merge branch 'atclen94' into atce4096-unity
d431d16
@budgetpreneur
updated latest c# to unity
5910295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crimsonred crimsonred crimsonred requested changes

@MikeDobrzan MikeDobrzan Awaiting requested review from MikeDobrzan

@mohitpubnub mohitpubnub Awaiting requested review from mohitpubnub mohitpubnub is a code owner

@parfeon parfeon Awaiting requested review from parfeon parfeon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@budgetpreneur @crimsonred @gnatogryz @MikeDobrzan