Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds rake tasks to gitignore #9882

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Conversation

abhiprojectz
Copy link
Contributor

Fixes #9860

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@welcome
Copy link

welcome bot commented Jul 5, 2021

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄

@gitpod-io
Copy link

gitpod-io bot commented Jul 5, 2021

@codeclimate
Copy link

codeclimate bot commented Jul 5, 2021

Code Climate has analyzed commit c8a5551 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #9882 (ede746a) into main (d12a468) will decrease coverage by 29.06%.
The diff coverage is 72.72%.

❗ Current head ede746a differs from pull request most recent head c8a5551. Consider uploading reports for the commit c8a5551 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9882       +/-   ##
===========================================
- Coverage   78.24%   49.17%   -29.07%     
===========================================
  Files          98       98               
  Lines        5947     6129      +182     
===========================================
- Hits         4653     3014     -1639     
- Misses       1294     3115     +1821     
Impacted Files Coverage Δ
app/channels/room_channel.rb 71.42% <0.00%> (ø)
app/controllers/tag_controller.rb 60.24% <ø> (-19.58%) ⬇️
app/helpers/application_helper.rb 71.87% <66.66%> (-8.34%) ⬇️
app/models/user.rb 60.85% <100.00%> (-21.95%) ⬇️
app/mailers/node_mailer.rb 0.00% <0.00%> (-100.00%) ⬇️
app/controllers/talk_controller.rb 0.00% <0.00%> (-100.00%) ⬇️
app/mailers/password_reset_mailer.rb 0.00% <0.00%> (-100.00%) ⬇️
app/models/drupal_content_field_mapper.rb 0.00% <0.00%> (-100.00%) ⬇️
app/models/drupal_content_field_map_editor.rb 0.00% <0.00%> (-100.00%) ⬇️
app/controllers/settings_controller.rb 0.00% <0.00%> (-88.89%) ⬇️
... and 48 more

Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhiprojectz LGTM 🎉

@cesswairimu
Copy link
Collaborator

Thanks @abhiprojectz and @Tlazypanda 🎉 🎉
merging now

@cesswairimu cesswairimu merged commit eea82a9 into publiclab:main Jul 6, 2021
@welcome
Copy link

welcome bot commented Jul 6, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

17sushmita pushed a commit to 17sushmita/plots2 that referenced this pull request Jul 7, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rake tasks to gitignore
3 participants