Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _header.html.erb #8607

Closed
wants to merge 1 commit into from
Closed

Conversation

frankiefab100
Copy link
Contributor

Updated the header

Fixes #8601

Updated the header
@welcome
Copy link

welcome bot commented Oct 17, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@gitpod-io
Copy link

gitpod-io bot commented Oct 17, 2020

@codeclimate
Copy link

codeclimate bot commented Oct 17, 2020

Code Climate has analyzed commit a92e984 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Oct 17, 2020

Codecov Report

Merging #8607 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8607   +/-   ##
=======================================
  Coverage   81.76%   81.76%           
=======================================
  Files         101      101           
  Lines        5901     5901           
=======================================
  Hits         4825     4825           
  Misses       1076     1076           

@frankiefab100
Copy link
Contributor Author

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

Twitter @frankiefab100

@cesswairimu
Copy link
Collaborator

Hello, I am sorry but it seems like this was solved in another PR #8602 . Closing this...Let me know if you need help finding another issue. Thanks

@frankiefab100
Copy link
Contributor Author

Yes, I do

@cesswairimu
Copy link
Collaborator

cool, adding your name here #7683 and will ping you when we get one for you. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace .length with .size in app/views/wiki/_header.html.erb
2 participants