update like_spec.js #11524

ijayhub · 2022-10-21T09:50:53Z

The code was in var an es5 way of declaring a variable changed it to let/const

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

PR is descriptively titled 📑 and links the original issue above 🔗
tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts 📁
screenshots/GIFs are attached 📎 in case of UI updation
ask @publiclab/reviewers for help, in a comment below

The code was in var an es5 way of declaring a variable changed it to const

welcome · 2022-10-21T09:50:56Z

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄

One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌

Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

gitpod-io · 2022-10-21T09:51:05Z

github-actions · 2022-10-21T10:01:10Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8892709265/artifacts/406744166

TildaDares · 2022-10-21T11:37:20Z

Hi @ijayhub, can you add a link to the issue?

One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the
format fixes #0000 (for example)

The code was in var an es5 way of declaring a variable changed it to const

ijayhub · 2022-10-21T15:52:11Z

okay

github-actions · 2022-10-21T15:58:00Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8898799669/artifacts/407167901

The code was in var an es5 way of declaring a variable changed it to let

github-actions · 2022-10-21T16:09:54Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8899008061/artifacts/407182791

codecov · 2022-10-21T16:11:53Z

Codecov Report

Merging #11524 (6d8d426) into main (83e0439) will increase coverage by 6.61%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11524      +/-   ##
==========================================
+ Coverage   76.71%   83.33%   +6.61%     
==========================================
  Files          93       93              
  Lines        5772     5772              
==========================================
+ Hits         4428     4810     +382     
+ Misses       1344      962     -382

Impacted Files	Coverage Δ
app/controllers/relationships_controller.rb	`71.42% <0.00%> (ø)`
app/controllers/users_controller.rb	`80.78% <0.00%> (+0.35%)`	⬆️
app/controllers/spam2_controller.rb	`72.54% <0.00%> (+0.98%)`	⬆️
app/controllers/user_tags_controller.rb	`83.78% <0.00%> (+1.35%)`	⬆️
app/controllers/admin_controller.rb	`80.24% <0.00%> (+1.64%)`	⬆️
app/controllers/search_controller.rb	`97.67% <0.00%> (+2.32%)`	⬆️
app/models/revision.rb	`88.29% <0.00%> (+3.19%)`	⬆️
app/models/node_tag.rb	`100.00% <0.00%> (+3.70%)`	⬆️
app/models/user.rb	`86.23% <0.00%> (+4.34%)`	⬆️
app/models/user_tag.rb	`100.00% <0.00%> (+4.34%)`	⬆️
... and 15 more

ijayhub · 2022-10-21T16:34:25Z

@TildaDares #11524

TildaDares · 2022-10-22T08:45:05Z

Hi @ijayhub, the link you added is for this PR. I'm asking for the issue this PR was opened for. Thanks!

ijayhub · 2022-10-22T11:11:31Z

hello @TildaDares , I didn't fix it from an issue. It was just an improvement I made while going through the code.
Thanks

TildaDares · 2022-10-22T17:35:56Z

Hi @ijayhub, we prefer to create issues first so that other contributors don't try to solve the same issues. It also gives the maintainers time to review the issue before you open a PR for it.

TildaDares · 2022-10-22T17:36:24Z

For example, it looks like @Josephsanya has opened a PR for one of the files you've added in this PR #11526.

TildaDares

Feel free to just click the Commit suggestion button. Thanks!

TildaDares · 2022-10-22T17:38:08Z

spec/javascripts/like_spec.js

@@ -19,12 +19,12 @@ describe("Like Button", function () {
    ajaxStub = sinon.stub($, 'ajax', function (object) {
      response = object.url === '/likes/node/1/create' ? '4' : 'none'

-      var d = $.Deferred();
+      let d = $.Deferred();


Suggested change

let d = $.Deferred();

const d = $.Deferred();

TildaDares · 2022-10-22T17:38:34Z

spec/javascripts/like_spec.js

@@ -65,7 +65,7 @@ describe("Like Button", function () {
    ajaxStub = sinon.stub($, 'ajax', function (object) {
      response = object.url === '/likes/node/1/delete' ? '4' : 'none'

-      var d = $.Deferred();
+      let d = $.Deferred();


Suggested change

let d = $.Deferred();

const d = $.Deferred();

TildaDares · 2022-10-22T17:38:42Z

spec/javascripts/like_spec.js

@@ -44,7 +44,7 @@ describe("Like Button", function () {
      //   console.log('Failed to fake response to:', object.url);
      // }

-      var d = $.Deferred();
+      let d = $.Deferred();


Suggested change

let d = $.Deferred();

const d = $.Deferred();

Josephsanya · 2022-10-24T02:49:12Z

Hi @ijayhub
Here is the link to the issue
#11537

ijayhub · 2022-10-24T07:11:24Z

Thank u

…

On Mon, Oct 24, 2022, 3:49 AM Jhowsef ***@***.***> wrote: Hi @ijayhub <https://github.com/ijayhub> Here is the link to the issue #11537 <#11537> — Reply to this email directly, view it on GitHub <#11524 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APYOQHNT5CR6HWROSCHLP4LWEX2LHANCNFSM6AAAAAARK77WOQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Josephsanya · 2022-10-24T10:16:13Z

Hey @ijayhub
You should make changes to your PR as requested and shown

fix: modified

ijayhub · 2022-10-24T18:43:38Z

modified

github-actions · 2022-10-24T19:36:37Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8936051920/artifacts/409990024

ijayhub · 2022-10-24T19:38:48Z

modified

TildaDares · 2022-10-25T06:28:01Z

Hi @ijayhub, can you make the changes I suggested above? Thank you!

codeclimate · 2022-10-25T07:13:29Z

Code Climate has analyzed commit 6d8d426 and detected 0 issues on this pull request.

View more on Code Climate.

github-actions · 2022-10-25T07:24:04Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8944112454/artifacts/410599312

TildaDares

Amazing @ijayhub. Thank you!

welcome · 2022-10-25T17:28:29Z

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

You can also join our Gitter channel to connect with other contributors 📥

update like_spec.js

2563918

The code was in var an es5 way of declaring a variable changed it to const

Update like_spec.js

14eb4bf

The code was in var an es5 way of declaring a variable changed it to const

Update like_spec.js

bd9eb3d

The code was in var an es5 way of declaring a variable changed it to let

TildaDares mentioned this pull request Oct 22, 2022

Modified functional scope to block scope in javascript #11526

Closed

5 tasks

TildaDares requested changes Oct 22, 2022

View reviewed changes

TildaDares linked an issue Oct 24, 2022 that may be closed by this pull request

Modify the functional scope to block scope in JavaScript using let and const in place of var #11537

Closed

5 tasks

Update like_spec.js

14c3610

fix: modified

Update like_spec.js

9a1b323

Update like_spec.js

6d8d426

TildaDares approved these changes Oct 25, 2022

View reviewed changes

TildaDares merged commit affe0fc into publiclab:main Oct 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update like_spec.js #11524

update like_spec.js #11524

ijayhub commented Oct 21, 2022 •

edited

Loading

welcome bot commented Oct 21, 2022

gitpod-io bot commented Oct 21, 2022

github-actions bot commented Oct 21, 2022

TildaDares commented Oct 21, 2022

ijayhub commented Oct 21, 2022

github-actions bot commented Oct 21, 2022

github-actions bot commented Oct 21, 2022

codecov bot commented Oct 21, 2022 •

edited

Loading

ijayhub commented Oct 21, 2022

TildaDares commented Oct 22, 2022

ijayhub commented Oct 22, 2022 •

edited

Loading

TildaDares commented Oct 22, 2022

TildaDares commented Oct 22, 2022

TildaDares left a comment

TildaDares Oct 22, 2022

TildaDares Oct 22, 2022

TildaDares Oct 22, 2022

Josephsanya commented Oct 24, 2022

ijayhub commented Oct 24, 2022 via email

Josephsanya commented Oct 24, 2022

ijayhub commented Oct 24, 2022

github-actions bot commented Oct 24, 2022

ijayhub commented Oct 24, 2022

TildaDares commented Oct 25, 2022

codeclimate bot commented Oct 25, 2022

github-actions bot commented Oct 25, 2022

TildaDares left a comment

welcome bot commented Oct 25, 2022

update like_spec.js #11524

update like_spec.js #11524

Conversation

ijayhub commented Oct 21, 2022 • edited Loading

welcome bot commented Oct 21, 2022

gitpod-io bot commented Oct 21, 2022

github-actions bot commented Oct 21, 2022

TildaDares commented Oct 21, 2022

ijayhub commented Oct 21, 2022

github-actions bot commented Oct 21, 2022

github-actions bot commented Oct 21, 2022

codecov bot commented Oct 21, 2022 • edited Loading

Codecov Report

ijayhub commented Oct 21, 2022

TildaDares commented Oct 22, 2022

ijayhub commented Oct 22, 2022 • edited Loading

TildaDares commented Oct 22, 2022

TildaDares commented Oct 22, 2022

TildaDares left a comment

Choose a reason for hiding this comment

TildaDares Oct 22, 2022

Choose a reason for hiding this comment

TildaDares Oct 22, 2022

Choose a reason for hiding this comment

TildaDares Oct 22, 2022

Choose a reason for hiding this comment

Josephsanya commented Oct 24, 2022

ijayhub commented Oct 24, 2022 via email

Josephsanya commented Oct 24, 2022

ijayhub commented Oct 24, 2022

github-actions bot commented Oct 24, 2022

ijayhub commented Oct 24, 2022

TildaDares commented Oct 25, 2022

codeclimate bot commented Oct 25, 2022

github-actions bot commented Oct 25, 2022

TildaDares left a comment

Choose a reason for hiding this comment

welcome bot commented Oct 25, 2022

ijayhub commented Oct 21, 2022 •

edited

Loading

codecov bot commented Oct 21, 2022 •

edited

Loading

ijayhub commented Oct 22, 2022 •

edited

Loading