Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subscription controller.io #11496

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Conversation

SylviaKaks
Copy link
Contributor

@SylviaKaks SylviaKaks commented Oct 17, 2022

Fixes #11490

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@welcome
Copy link

welcome bot commented Oct 17, 2022

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@gitpod-io
Copy link

gitpod-io bot commented Oct 17, 2022

@codeclimate
Copy link

codeclimate bot commented Oct 17, 2022

Code Climate has analyzed commit 2f8e43c and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8803646777/artifacts/400379904

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #11496 (2f8e43c) into main (a5d2483) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #11496   +/-   ##
=======================================
  Coverage   83.33%   83.33%           
=======================================
  Files          93       93           
  Lines        5772     5772           
=======================================
  Hits         4810     4810           
  Misses        962      962           
Impacted Files Coverage Δ
app/controllers/subscription_controller.rb 76.00% <100.00%> (ø)

@SylviaKaks
Copy link
Contributor Author

@TildaDares and @jywarren kindly review my PR. Any corrections are welcome

@TildaDares
Copy link
Member

Hi @SylviaKaks, can you add a link to the issue?

One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the
format fixes #0000 (for example)

@SylviaKaks
Copy link
Contributor Author

@TildaDares do you mean a link like this - #11496 ?

@cesswairimu
Copy link
Collaborator

She meant #11490 I have updated, thanks

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉 , thanks for working on this. Please add the issue link in future to help in reviewing.

@cesswairimu cesswairimu merged commit 39726e8 into publiclab:main Oct 24, 2022
@welcome
Copy link

welcome bot commented Oct 24, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

You can also join our Gitter channel to connect with other contributors 📥

@SylviaKaks
Copy link
Contributor Author

thanks for the review. Will include the link next time. @cesswairimu

@SylviaKaks SylviaKaks deleted the patch-1 branch October 24, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix "click to unfollow is not working in /tag section"
3 participants