-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inverted negation for if/else statement #11484
Conversation
- Inverted the statement such that when the user is nil,there is a rejection Fixes #11417
Code Climate has analyzed commit dd2ab0f and detected 0 issues on this pull request. View more on Code Climate. |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #11484 +/- ##
=======================================
Coverage 83.33% 83.33%
=======================================
Files 93 93
Lines 5772 5772
=======================================
Hits 4810 4810
Misses 962 962
|
@Josephsanya please can you review this issue that was assigned to me? |
You did well |
Thank you @Josephsanya |
@TildaDares please can you review this issue that was assigned to me? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job @Emenyi95. Thank you!
Thank you for the reviews @Josephsanya! |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. You can also join our Gitter channel to connect with other contributors 📥 |
Congratulations on merging your PR @Emenyi95 🎉 |
Congratulations @Emenyi95 🍾🎉 |
Happy to help @TildaDares |
Thank you @TildaDares.
…On Fri, 14 Oct 2022 at 15:33 Tilda Udufo ***@***.***> wrote:
***@***.**** approved this pull request.
Amazing job @Emenyi95 <https://github.com/Emenyi95>. Thank you!
—
Reply to this email directly, view it on GitHub
<#11484 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZY2B6JXNPQGFQFW7OKHHHLWDFVKBANCNFSM6AAAAAARFEE5KM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Inverted the statement such that when the user is nil,there is a rejection Fixes Rubocop-fix: Invert negation in if/else #11417
Inverted negation in if/else statement such that there is a rejection when user is nil
Fixes Rubocop-fix: Invert negation in if/else #11417