Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inverted negation for if/else statement #11484

Merged
merged 1 commit into from Oct 14, 2022
Merged

Inverted negation for if/else statement #11484

merged 1 commit into from Oct 14, 2022

Conversation

ghost
Copy link

@ghost ghost commented Oct 14, 2022

- Inverted the statement such that when the user is nil,there is a rejection
Fixes #11417
@gitpod-io
Copy link

gitpod-io bot commented Oct 14, 2022

@codeclimate
Copy link

codeclimate bot commented Oct 14, 2022

Code Climate has analyzed commit dd2ab0f and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8775390270/artifacts/398229526

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #11484 (dd2ab0f) into main (21dfe4c) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #11484   +/-   ##
=======================================
  Coverage   83.33%   83.33%           
=======================================
  Files          93       93           
  Lines        5772     5772           
=======================================
  Hits         4810     4810           
  Misses        962      962           
Impacted Files Coverage Δ
app/channels/user_channel.rb 83.33% <100.00%> (ø)

@ghost
Copy link
Author

ghost commented Oct 14, 2022

@Josephsanya please can you review this issue that was assigned to me?

@Josephsanya
Copy link
Contributor

You did well
Let's wait for the mentors to approve @TildaDares

@ghost
Copy link
Author

ghost commented Oct 14, 2022

Thank you @Josephsanya

@ghost
Copy link
Author

ghost commented Oct 14, 2022

@TildaDares please can you review this issue that was assigned to me?

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job @Emenyi95. Thank you!

@TildaDares
Copy link
Member

Thank you for the reviews @Josephsanya!

@TildaDares TildaDares merged commit 9c25346 into publiclab:main Oct 14, 2022
@welcome
Copy link

welcome bot commented Oct 14, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

You can also join our Gitter channel to connect with other contributors 📥

@TildaDares
Copy link
Member

Congratulations on merging your PR @Emenyi95 🎉

@7malikk
Copy link
Contributor

7malikk commented Oct 14, 2022

Congratulations @Emenyi95 🍾🎉

@Josephsanya
Copy link
Contributor

Happy to help @TildaDares
Well-done @Emenyi95

@ghost
Copy link
Author

ghost commented Oct 14, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rubocop-fix: Invert negation in if/else
3 participants