Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified navigation-bar #11053

Merged
merged 3 commits into from
May 7, 2022
Merged

Modified navigation-bar #11053

merged 3 commits into from
May 7, 2022

Conversation

simransia
Copy link
Contributor

@simransia simransia commented Apr 13, 2022

I have fixed the alignment of the "About us" nav-link and have also made the widths of both the "Store" and "Donate" buttons equal. Also, I have changed the about_title present in the en.yml file from "About us" to "About Us".
This will make the navigation bar look better 😇

Here is the screenshot:

Screenshot **(127)

Here is the video:

video.mp4

Fixes #11049

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@simransia simransia requested a review from a team as a code owner April 13, 2022 19:20
@gitpod-io
Copy link

gitpod-io bot commented Apr 13, 2022

@TildaDares
Copy link
Member

HI @simransia, can you add screenshots? Thanks!!

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/6114028840/artifacts/212527003

@simransia
Copy link
Contributor Author

HI @simransia, can you add screenshots? Thanks!!

Hello @TildaDares I have attached the screenshot and video of the navbar.

Thank you so much for guiding me patiently about my mistakes!

@TildaDares
Copy link
Member

@simransia The navbar items are misplaced on smaller screens

Screenshot 2022-04-14 at 17 23 01

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/6132168423/artifacts/213650877

@simransia
Copy link
Contributor Author

simransia commented Apr 15, 2022

@simransia The navbar items are misplaced on smaller screens

Screenshot 2022-04-14 at 17 23 01

Hello @TildaDares, I have fixed this issue by using media queries and sorry for not recognizing this issue before.
Now the nav-links are looking fine on smaller screens also and the buttons are having a little space between them. You can view it in the screenshot below. Thank You.

@TildaDares
Copy link
Member

@simransia From screen size 576px - 768px, the store and donate buttons don't show.

@simransia
Copy link
Contributor Author

@simransia From screen size 576px - 768px, the store and donate buttons don't show.

@TildaDares mam, On the mention screen sizes, those buttons were already not showing from starting even before I have started modifying the navigation bar.

This is the screenshot of the present working website of public lab:

Screenshot (152)

@TildaDares
Copy link
Member

@simransia You're right. Do you think you could add them? Thank you!!

@simransia
Copy link
Contributor Author

@simransia You're right. Do you think you could add them? Thank you!!

Yes @TildaDares mam, I can add them. I have just now tried adding them and they are occupying the full width of the page after getting added. So, I want to know your preference. You can choose one from the below images:

Are they looking good like this:

Screenshot (157)

Or should I make their width smaller like this:

Screenshot (156)

@TildaDares
Copy link
Member

@simransia The first image is better. Thanks!!

@codeclimate
Copy link

codeclimate bot commented Apr 16, 2022

Code Climate has analyzed commit 2606e61 and detected 0 issues on this pull request.

View more on Code Climate.

@simransia
Copy link
Contributor Author

@simransia The first image is better. Thanks!!

Hello @TildaDares. I have added the 'store' and 'donate' buttons on the mentioned screen sizes successfully. And I am ready to do any further modifications if needed.

Thank You so much!

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/6145074502/artifacts/214532945

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working this @simransia!!

@welcome
Copy link

welcome bot commented May 7, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@TildaDares
Copy link
Member

Thank you @simransia!!

@simransia
Copy link
Contributor Author

Thank you @simransia!!

It's my pleasure @TildaDares !
I am so happy working on this! 🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants