-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified navigation-bar #11053
Modified navigation-bar #11053
Conversation
HI @simransia, can you add screenshots? Thanks!! |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
Hello @TildaDares I have attached the screenshot and video of the navbar. Thank you so much for guiding me patiently about my mistakes! |
@simransia The navbar items are misplaced on smaller screens |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
Hello @TildaDares, I have fixed this issue by using media queries and sorry for not recognizing this issue before. |
@simransia From screen size 576px - 768px, the |
@TildaDares mam, On the mention screen sizes, those buttons were already not showing from starting even before I have started modifying the navigation bar. This is the screenshot of the present working website of public lab: |
@simransia You're right. Do you think you could add them? Thank you!! |
Yes @TildaDares mam, I can add them. I have just now tried adding them and they are occupying the full width of the page after getting added. So, I want to know your preference. You can choose one from the below images: Are they looking good like this: Or should I make their width smaller like this: |
@simransia The first image is better. Thanks!! |
Code Climate has analyzed commit 2606e61 and detected 0 issues on this pull request. View more on Code Climate. |
Hello @TildaDares. I have added the 'store' and 'donate' buttons on the mentioned screen sizes successfully. And I am ready to do any further modifications if needed. Thank You so much! |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working this @simransia!!
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Thank you @simransia!! |
It's my pleasure @TildaDares ! |
I have fixed the alignment of the "About us" nav-link and have also made the widths of both the "Store" and "Donate" buttons equal. Also, I have changed the about_title present in the en.yml file from "About us" to "About Us".
This will make the navigation bar look better 😇
Here is the screenshot:
Here is the video:
video.mp4
Fixes #11049
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below