Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the missing translations #11047

Merged
merged 6 commits into from
Apr 13, 2022
Merged

Added the missing translations #11047

merged 6 commits into from
Apr 13, 2022

Conversation

Ishika414
Copy link
Contributor

Updated _tagging.html.erb, Updated en.yml, Updated fr.yml
Fixes #10986

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@gitpod-io
Copy link

gitpod-io bot commented Apr 13, 2022

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #11047 (77153a6) into main (5647c5b) will decrease coverage by 79.49%.
The diff coverage is n/a.

❗ Current head 77153a6 differs from pull request most recent head 8a6cc80. Consider uploading reports for the commit 8a6cc80 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #11047       +/-   ##
===========================================
- Coverage   81.26%    1.77%   -79.50%     
===========================================
  Files          98       98               
  Lines        5990     8963     +2973     
===========================================
- Hits         4868      159     -4709     
- Misses       1122     8804     +7682     
Impacted Files Coverage Δ
app/models/like.rb 0.00% <0.00%> (-100.00%) ⬇️
lib/text_search.rb 0.00% <0.00%> (-100.00%) ⬇️
app/models/csvfile.rb 0.00% <0.00%> (-100.00%) ⬇️
app/models/node_tag.rb 0.00% <0.00%> (-100.00%) ⬇️
app/models/user_tag.rb 0.00% <0.00%> (-100.00%) ⬇️
app/helpers/map_helper.rb 0.00% <0.00%> (-100.00%) ⬇️
app/helpers/tag_helper.rb 0.00% <0.00%> (-100.00%) ⬇️
app/helpers/home_helper.rb 0.00% <0.00%> (-100.00%) ⬇️
app/helpers/wiki_helper.rb 0.00% <0.00%> (-100.00%) ⬇️
app/mailers/node_mailer.rb 0.00% <0.00%> (-100.00%) ⬇️
... and 82 more

config/locales/en.yml Outdated Show resolved Hide resolved
config/locales/fr.yml Outdated Show resolved Hide resolved
Ishika414 and others added 2 commits April 13, 2022 12:10
@codeclimate
Copy link

codeclimate bot commented Apr 13, 2022

Code Climate has analyzed commit 8a6cc80 and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/6103925438/artifacts/211897308

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Ishika414. Thanks!!

@TildaDares TildaDares merged commit abd1465 into publiclab:main Apr 13, 2022
@welcome
Copy link

welcome bot commented Apr 13, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@TildaDares
Copy link
Member

Congratulations @Ishika414 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing translation of "This is part of" on _tagging.html.erb
2 participants