Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CSS selector #links li #11022

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Conversation

OLIPLICHE
Copy link
Contributor

@OLIPLICHE OLIPLICHE commented Apr 11, 2022

I updated CSS Selector #links li{ }, take your time to review my code

Fixes #11012

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@welcome
Copy link

welcome bot commented Apr 11, 2022

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@gitpod-io
Copy link

gitpod-io bot commented Apr 11, 2022

@codeclimate
Copy link

codeclimate bot commented Apr 11, 2022

Code Climate has analyzed commit b6d7466 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #11022 (14862df) into main (f22b3c8) will decrease coverage by 0.11%.
The diff coverage is n/a.

❗ Current head 14862df differs from pull request most recent head b6d7466. Consider uploading reports for the commit b6d7466 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11022      +/-   ##
==========================================
- Coverage   82.45%   82.33%   -0.12%     
==========================================
  Files          98       98              
  Lines        5990     5990              
==========================================
- Hits         4939     4932       -7     
- Misses       1051     1058       +7     
Impacted Files Coverage Δ
app/services/execute_search.rb 88.88% <0.00%> (-5.56%) ⬇️
app/api/srch/search.rb 66.66% <0.00%> (-3.85%) ⬇️

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/6067403886/artifacts/209676008

@TildaDares
Copy link
Member

Hi @OLIPLICHE, can you add a link to the issue? The issue number is the number at the top of the issue(next to the issue title) you were assigned. Thanks!

One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the
format fixes #0000 (for example)

@OLIPLICHE
Copy link
Contributor Author

OLIPLICHE commented Apr 11, 2022

Hi @OLIPLICHE, can you add a link to the issue? The issue number is the number at the top of the issue(next to the issue title) you were assigned. Thanks!

One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the
format fixes #0000 (for example)

I hope it's okay. because I am little be confused. I have updated it to "11022" @TildaDares
w1

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @OLIPLICHE. Well done!!

@welcome
Copy link

welcome bot commented Apr 12, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@TildaDares
Copy link
Member

Congratulations @OLIPLICHE 🎉 and thanks for the review @debck!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repetition of CSS selectors
3 participants