-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edited line 26
of show.html.erb
#10991
Conversation
Added space to the question for a better user experience on `line 26`
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Code Climate has analyzed commit 89808d8 and detected 0 issues on this pull request. View more on Code Climate. |
line 26
of shot.html.erbline 26
of show.html.erb
Codecov Report
@@ Coverage Diff @@
## main #10991 +/- ##
==========================================
+ Coverage 82.33% 82.45% +0.11%
==========================================
Files 98 98
Lines 5990 5990
==========================================
+ Hits 4932 4939 +7
+ Misses 1058 1051 -7
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
@Abdulrahim2567 Great FTO 👍 Just next time you can put number of issue to the next line looking like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @Abdulrahim2567!!
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Congratulations @Abdulrahim2567 🎉 |
@TildaDares thank you very much for the support :). Is there any issue which I could work on next? |
@Abdulrahim2567 You can look out for issues with the help-wanted or bug tag or create FTOs for another first-timer. |
okay thanks a lot I will do just that :) |
An attempt to fix issue #10982 Added space to the question for a better user experience on
line 26
Fixes #0000
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below