-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update _flags.html.erb #10966
Update _flags.html.erb #10966
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Hi @Dapper50, can you add the issue number in the description above? It should be in the format |
Codecov Report
@@ Coverage Diff @@
## main #10966 +/- ##
===========================================
+ Coverage 25.86% 82.45% +56.58%
===========================================
Files 98 98
Lines 7689 5991 -1698
===========================================
+ Hits 1989 4940 +2951
+ Misses 5700 1051 -4649
|
@TildaDares done |
@Dapper50 The issue number is the number at the top of the issue you were assigned. It starts with a # |
@TildaDares apologies for mix up, I have updated it. |
Hi @Dapper50, I can't find the issue number. |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
Feel free to commit all of those suggestions!! |
Hi @TildaDares i have update the issue number with PR #10966 |
@Dapper50 Navigate to the issue you were assigned to, look at the top of the page, next to the issue's title you'll find a number that begins with #. That's the issue number. |
Hi @Dapper50, do you need any help with this? |
Yes please @TildaDares |
@Dapper50 What do you need help with? |
@TildaDares the changes I made I wanted to confirm if it is correct, or if I would require to redo it |
@Dapper50 You don't have to redo anything. All you have to do is press those |
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>
@TildaDares apologies for the mix up i just finished doing it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @Dapper50. Thank you!!
Code Climate has analyzed commit 69a4bb0 and detected 0 issues on this pull request. View more on Code Climate. |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Congratulations @Dapper50 🎉 |
@TildaDares thank you so much for your support |
Fixes
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below