Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _flags.html.erb #10966

Merged
merged 40 commits into from
Apr 14, 2022
Merged

Update _flags.html.erb #10966

merged 40 commits into from
Apr 14, 2022

Conversation

Dapper50
Copy link
Contributor

@Dapper50 Dapper50 commented Apr 6, 2022

Fixes

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@welcome
Copy link

welcome bot commented Apr 6, 2022

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@gitpod-io
Copy link

gitpod-io bot commented Apr 6, 2022

@TildaDares
Copy link
Member

Hi @Dapper50, can you add the issue number in the description above? It should be in the format fixes #0000. Thanks!

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #10966 (b217ab4) into main (cc08d12) will increase coverage by 56.58%.
The diff coverage is n/a.

❗ Current head b217ab4 differs from pull request most recent head 12bd759. Consider uploading reports for the commit 12bd759 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #10966       +/-   ##
===========================================
+ Coverage   25.86%   82.45%   +56.58%     
===========================================
  Files          98       98               
  Lines        7689     5991     -1698     
===========================================
+ Hits         1989     4940     +2951     
+ Misses       5700     1051     -4649     
Impacted Files Coverage Δ
app/models/revision.rb 88.29% <0.00%> (+3.19%) ⬆️
app/models/node_tag.rb 100.00% <0.00%> (+3.70%) ⬆️
app/models/image.rb 82.05% <0.00%> (+5.12%) ⬆️
app/models/tag.rb 93.23% <0.00%> (+5.79%) ⬆️
app/models/concerns/node_shared.rb 90.29% <0.00%> (+6.31%) ⬆️
app/models/concerns/statistics.rb 100.00% <0.00%> (+6.55%) ⬆️
app/models/tag_selection.rb 96.00% <0.00%> (+8.00%) ⬆️
app/models/user.rb 86.64% <0.00%> (+9.38%) ⬆️
app/models/doc_list.rb 65.00% <0.00%> (+10.00%) ⬆️
app/models/node.rb 91.27% <0.00%> (+14.42%) ⬆️
... and 52 more

@Dapper50
Copy link
Contributor Author

Dapper50 commented Apr 6, 2022

@TildaDares done

@TildaDares
Copy link
Member

@Dapper50 The issue number is the number at the top of the issue you were assigned. It starts with a #

@Dapper50
Copy link
Contributor Author

Dapper50 commented Apr 7, 2022

@TildaDares apologies for mix up, I have updated it.

@TildaDares
Copy link
Member

Hi @Dapper50, I can't find the issue number.

@github-actions
Copy link

github-actions bot commented Apr 7, 2022

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5976851782/artifacts/205723816

app/views/spam2/_flags.html.erb Outdated Show resolved Hide resolved
app/views/spam2/_flags.html.erb Outdated Show resolved Hide resolved
app/views/spam2/_flags.html.erb Outdated Show resolved Hide resolved
app/views/spam2/_flags.html.erb Outdated Show resolved Hide resolved
app/views/spam2/_flags.html.erb Outdated Show resolved Hide resolved
app/views/spam2/_flags.html.erb Outdated Show resolved Hide resolved
app/views/spam2/_flags.html.erb Outdated Show resolved Hide resolved
app/views/spam2/_flags.html.erb Outdated Show resolved Hide resolved
app/views/spam2/_flags.html.erb Outdated Show resolved Hide resolved
app/views/spam2/_flags.html.erb Show resolved Hide resolved
@TildaDares
Copy link
Member

Feel free to commit all of those suggestions!!

@Dapper50
Copy link
Contributor Author

Dapper50 commented Apr 7, 2022

Hi @TildaDares i have update the issue number with PR #10966

@TildaDares
Copy link
Member

@Dapper50 Navigate to the issue you were assigned to, look at the top of the page, next to the issue's title you'll find a number that begins with #. That's the issue number.

@TildaDares
Copy link
Member

Hi @Dapper50, do you need any help with this?

@Dapper50
Copy link
Contributor Author

Yes please @TildaDares

@TildaDares
Copy link
Member

@Dapper50 What do you need help with?

@Dapper50
Copy link
Contributor Author

@TildaDares the changes I made I wanted to confirm if it is correct, or if I would require to redo it

@TildaDares
Copy link
Member

@Dapper50 You don't have to redo anything. All you have to do is press those Commit suggestion buttons and we should be good.

Dapper50 and others added 19 commits April 13, 2022 20:03
@Dapper50
Copy link
Contributor Author

@TildaDares apologies for the mix up i just finished doing it.

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @Dapper50. Thank you!!

@codeclimate
Copy link

codeclimate bot commented Apr 13, 2022

Code Climate has analyzed commit 69a4bb0 and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/6113961891/artifacts/212524371

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/6113961891/artifacts/213328505

@TildaDares TildaDares merged commit a19e33a into publiclab:main Apr 14, 2022
@welcome
Copy link

welcome bot commented Apr 14, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@TildaDares
Copy link
Member

Congratulations @Dapper50 🎉

@Dapper50
Copy link
Contributor Author

@TildaDares thank you so much for your support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants