-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cw721-sylvia-base
#127
base: main
Are you sure you want to change the base?
cw721-sylvia-base
#127
Conversation
Top line thought: this is useful to have in the repo. If Sylvia becomes more widely adopted, we should begin to provide a 'paved path'. If it doesn't, then it's either still useful documentation for somebody, or could be hypothetically removed later (although, personally once something is in, I think we should maintain it, see below).
Depending on the effort to do so, yes, because they are widely in production and it's probably better to offer alternatives rather than hard deprecate a given pattern.
No strong thoughts on this one as don't personally use Sylvia.
I guess as referred to in my first response I think folks that want to focus on Sylvia can put those contracts here so that other people can use them, but if people don't want to use Sylvia, then that's valid. Any framework usually has some drawbacks WRT flexibility and from my understanding the same is true here. There's another question of whether it's more approachable to beginners. My guess would be no, as there's a bit more upfront type stuff to parse in exchange for simpler definitions of data, but could be wrong about that! |
Added more tests, coverage should be decent by now. Will add a template for a basic sylvia cw721 contract after this is reviewed. |
Requires setting `resolver = "2"` in the workspace. See: https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions
Needed for latest sylvia version it seems
Adds a similar contract to
cw721-base
but written with the Sylvia smart contract framework.There are a few advantages to Sylvia over the extension based pattern we currently have:
ExecuteMsg::Extension
.Have some open questions which I would love folks thoughts on if they have them:
Closes #31 hopefully someday 🤞