Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new directives for including files #14

Closed
wants to merge 1 commit into from

Conversation

rlidwka
Copy link

@rlidwka rlidwka commented Feb 20, 2012

I submitted an issue here:
https://github.com/TrevorBurnham/connect-assets/issues/73

This patch introduces two new keywords:

=include FILE for including file to source

=include_str FILE for including file with escaping some special characters

My patch just replacing #=include with file's contents. It doesn't register FILE as a dependency (I dont know how to do it). So, there might be some problems with it.

I didn't include compiled snockets.js because I have custom version of compiler and there will be too many unrelated diffs.

I couldn't write tests because of this:

squogre:snockets:% cake test
The "sys" module is now called "util". It should have a similar interface.

/home/alex/node_modules/snockets/node_modules/watch-tree/lib/watchers/stat.js:148
        throw err;
              ^
Error: ENOTDIR, not a directory 'test/integration.coffee'

But it works for me... so far so good. And it definitely better than nothing.

@pthrasher
Copy link
Owner

What value do these new directives add? Is it simply for injecting a string in place into the file?

@pthrasher
Copy link
Owner

I'm closing this issue. Please refer to #34 for updates as this functionality may be added soon.

@pthrasher pthrasher closed this May 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants