Merge pull request #600 from mountaindude/587

build: Switch from pkg to Node SEA for creating binaries
ptarmiganlabs · Nov 6, 2024 · d3eff5a · d3eff5a
2 parents f42fa8f + 4b725b2
commit d3eff5a
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 40 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -35,9 +35,6 @@ jobs:
           cd src
           npm ci --include=dev --include=prod
 
-      # - name: Make sure Jest is installed
-      #   run: npm install jest
-
       - name: Debugging 2
         run: |
           pwd
@@ -170,9 +167,6 @@ jobs:
           cd src
           npm ci --include=dev --include=prod
 
-      # - name: Make sure Jest is installed
-      #   run: npm install jest
-
       - name: Debugging 2
         run: |
           dir 
@@ -422,28 +416,6 @@ jobs:
 
           ls -la
 
-      # - name: Download-Binaries
-      #   uses: actions/download-artifact@v3
-      #   with:
-      #     name: release-binaries-macos
-      #     path: release-macos/
-
-      # - name: Make binary executable
-      #   run: |
-      #     chmod +x release-macos/${DIST_FILE_NAME}
-
-      # - name: Debug
-      #   run: |
-      #     ls -la
-      #     ls -la ./release-macos
-
-      # - name: Change name of zip file
-      #   run: |
-      #     pwd
-      #     ls -la
-      #     ls -la ./release-macos
-      #     mv ./${{ env.DIST_FILE_NAME }}-macos.zip ./${{ needs.release-please.outputs.release_tag_name }}-macos.zip
-
       - name: Upload to existing release
         uses: ncipollo/release-action@v1
         with:
@@ -561,10 +533,6 @@ jobs:
           Remove-Item -Force build.cjs
 
           dir
-      # - name: Debug
-      #   run: |
-      #     dir
-      #     dir ./release-win
 
       - name: Upload to existing release
         uses: ncipollo/release-action@v1
@@ -573,7 +541,6 @@ jobs:
           omitBodyDuringUpdate: true
           omitNameDuringUpdate: true
           artifactContentType: raw
-          # artifactContentType: application/zip
           draft: true
           tag: ${{ needs.release-please.outputs.release_tag_name }}
           artifacts: ./${{ needs.release-please.outputs.release_tag_name }}-win.zip
@@ -649,7 +616,6 @@ jobs:
           omitBodyDuringUpdate: true
           omitNameDuringUpdate: true
           artifactContentType: raw
-          # artifactContentType: application/zip
           draft: true
           tag: ${{ needs.release-please.outputs.release_tag_name }}
           artifacts: ./${{ needs.release-please.outputs.release_tag_name }}-linux.zip

diff --git a/.github/workflows/insiders-build.yaml b/.github/workflows/insiders-build.yaml
@@ -223,12 +223,6 @@ jobs:
           pwd
           ${{ matrix.build }}
 
-      # - name: Upload release artifacts to GitHub
-      #   uses: actions/upload-artifact@v3
-      #   with:
-      #     name: ${{ matrix.artifact_release_name }}
-      #     path: ${{ matrix.artifact_release_path }}
-
       - name: Upload insider build artifacts to GitHub
         uses: actions/upload-artifact@v4
         with: