Fix handling of large messages (when multiple Serial.readBytes call need to get a message through the serial line) #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the SmartMeter sends large messages (>1KB) these will not fit in a single buffer, will not be available for reading in one go. This will cause CRC errors. Reorganised steps. Moved buffer cleanup after the last line is received (line starting with !). Moved creating new ParsedMessages out of the reading loop. This avoids possibly resetting previously parsed values. Also avoids buffer cleanup causing bad CRC when large messages (>1KB) are coming through the serial line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the SmartMeter sends large messages (>1KB) these will not fit in a single buffer, will not be available for reading in one go. This will cause CRC errors.
Reorganised steps. Moved buffer cleanup after the last line is received (line starting with !).
Moved creating new ParsedMessages out of the reading loop.
This avoids possibly resetting previously parsed values. Also avoids buffer cleanup causing bad CRC when large messages (>1KB) are coming through the serial line.