Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injecting lp sftp username so it is not public. #65

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

ajkiessl
Copy link
Contributor

@ajkiessl ajkiessl commented Jan 18, 2024

We changed our username for this SFTP bucket sometime in the past year. We share this with ETDA and never transitioned the username here — in FAMS Tools. For a little extra security, I changed how the username is set to inject it via a config setting.

Copy link
Contributor

@Smullz622 Smullz622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ajkiessl ajkiessl merged commit 7acf9e6 into main Jan 19, 2024
4 checks passed
@ajkiessl ajkiessl deleted the inject-lp-username branch January 19, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants