Add College of Medicine integration

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2023-09-07 18:53:06 UTC using RuboCop version 1.42.0.
+# on 2023-09-26 15:01:40 UTC using RuboCop version 1.42.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -20,7 +20,7 @@ FactoryBot/FactoryAssociationWithStrategy:
     - 'spec/factories/personal_contact.rb'
     - 'spec/factories/yearly.rb'
 
-# Offense count: 67
+# Offense count: 73
 # This cop supports unsafe autocorrection (--autocorrect-all).
 FactoryBot/SyntaxMethods:
   Enabled: false
@@ -38,10 +38,12 @@ Lint/AmbiguousBlockAssociation:
   Exclude:
     - 'spec/jobs/application_job_spec.rb'
 
-# Offense count: 18
+# Offense count: 22
 # This cop supports unsafe autocorrection (--autocorrect-all).
 Lint/NonAtomicFileOperation:
   Exclude:
+    - 'app/jobs/com_effort_integrate_job.rb'
+    - 'app/jobs/com_quality_integrate_job.rb'
     - 'app/jobs/delete_records_job.rb'
     - 'app/jobs/lionpath_integrate_job.rb'
     - 'app/jobs/osp_integrate_job.rb'
@@ -54,17 +56,22 @@ Lint/ShadowingOuterLocalVariable:
   Exclude:
     - 'app/models/concerns/spreadsheet_output.rb'
 
-# Offense count: 1
+# Offense count: 4
 # Configuration parameters: AllowComments, AllowNil.
 Lint/SuppressedException:
   Exclude:
+    - 'app/importers/com_data/com_effort_populate_db.rb'
+    - 'app/importers/com_data/com_quality_populate_db.rb'
     - 'app/importers/lionpath_data/lionpath_populate_db.rb'
+    - 'spec/importers/com_data/com_quality_xml_builder_spec.rb'
 
-# Offense count: 3
+# Offense count: 5
 # Configuration parameters: AllowKeywordBlockArguments.
 Lint/UnderscorePrefixedVariableName:
   Exclude:
     - 'app/jobs/application_job.rb'
+    - 'app/jobs/com_effort_integrate_job.rb'
+    - 'app/jobs/com_quality_integrate_job.rb'
     - 'app/jobs/lionpath_integrate_job.rb'
     - 'app/jobs/osp_integrate_job.rb'
 
@@ -78,7 +85,7 @@ Lint/UselessAssignment:
     - 'spec/importers/ldap_data/import_ldap_data_spec.rb'
     - 'spec/importers/pub_data/get_pub_data_spec.rb'
 
-# Offense count: 33
+# Offense count: 37
 # Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods, CountRepeatedAttributes.
 Metrics/AbcSize:
   Max: 276
@@ -94,17 +101,17 @@ Metrics/BlockLength:
 Metrics/ClassLength:
   Max: 169
 
-# Offense count: 12
+# Offense count: 13
 # Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods.
 Metrics/CyclomaticComplexity:
   Max: 39
 
-# Offense count: 46
+# Offense count: 53
 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods.
 Metrics/MethodLength:
   Max: 153
 
-# Offense count: 12
+# Offense count: 13
 # Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods.
 Metrics/PerceivedComplexity:
   Max: 40
@@ -139,7 +146,7 @@ Naming/VariableNumber:
     - 'spec/integration/ai_integration/yearly_integration_spec.rb'
     - 'spec/models/concerns/work_outputs_spec.rb'
 
-# Offense count: 32
+# Offense count: 38
 RSpec/AnyInstance:
   Exclude:
     - 'spec/importers/activity_insight/delete_records_spec.rb'
@@ -160,39 +167,26 @@ RSpec/BeEq:
     - 'spec/models/integration_spec.rb'
     - 'spec/models/verify_post_print_spec.rb'
 
-# Offense count: 5
+# Offense count: 7
 # Configuration parameters: IgnoredMetadata.
 RSpec/DescribeClass:
   Exclude:
+    - 'spec/integration/ai_integration/com_effort_integration_spec.rb'
+    - 'spec/integration/ai_integration/com_quality_integration_spec.rb'
     - 'spec/integration/ai_integration/ldap_integration_spec.rb'
     - 'spec/integration/ai_integration/lionpath_integration_spec.rb'
     - 'spec/integration/ai_integration/osp_integration_spec.rb'
     - 'spec/integration/ai_integration/publications_integration_spec.rb'
     - 'spec/integration/ai_integration/yearly_integration_spec.rb'
 
-# Offense count: 40
+# Offense count: 44
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: SkipBlocks, EnforcedStyle.
 # SupportedStyles: described_class, explicit
 RSpec/DescribedClass:
-  Exclude:
-    - 'spec/importers/activity_insight/ai_integrate_data_spec.rb'
-    - 'spec/importers/activity_insight/ai_manage_duplicates_spec.rb'
-    - 'spec/importers/activity_insight/delete_records_spec.rb'
-    - 'spec/importers/activity_insight/get_user_data_spec.rb'
-    - 'spec/importers/ldap_data/import_ldap_data_spec.rb'
-    - 'spec/importers/ldap_data/ldap_xml_builder_spec.rb'
-    - 'spec/importers/lionpath_data/lionpath_parser_spec.rb'
-    - 'spec/importers/lionpath_data/lionpath_populate_db_spec.rb'
-    - 'spec/importers/lionpath_data/lionpath_xml_builder_spec.rb'
-    - 'spec/importers/osp_data/osp_importer_spec.rb'
-    - 'spec/importers/pub_data/get_pub_data_spec.rb'
-    - 'spec/importers/pub_data/pub_populate_db_spec.rb'
-    - 'spec/importers/pub_data/pub_xml_builder_spec.rb'
-    - 'spec/importers/yearly_data/yearly_data_importer_spec.rb'
-    - 'spec/models/integration_spec.rb'
+  Enabled: false
 
-# Offense count: 41
+# Offense count: 49
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
   Max: 84
@@ -220,14 +214,18 @@ RSpec/FilePath:
     - 'spec/integration/cv_parser_spec.rb'
     - 'spec/integration/main_spec.rb'
 
-# Offense count: 45
+# Offense count: 53
 # Configuration parameters: Max, AllowedIdentifiers, AllowedPatterns.
 RSpec/IndexedLet:
   Exclude:
+    - 'spec/importers/com_data/com_effort_populate_db_spec.rb'
+    - 'spec/importers/com_data/com_quality_populate_db_spec.rb'
     - 'spec/importers/lionpath_data/lionpath_parser_spec.rb'
     - 'spec/importers/osp_data/osp_importer_spec.rb'
     - 'spec/importers/osp_data/osp_xml_builder_spec.rb'
     - 'spec/importers/yearly_data/yearly_xml_builder_spec.rb'
+    - 'spec/integration/ai_integration/com_effort_integration_spec.rb'
+    - 'spec/integration/ai_integration/com_quality_integration_spec.rb'
     - 'spec/integration/ai_integration/lionpath_integration_spec.rb'
     - 'spec/integration/ai_integration/osp_integration_spec.rb'
     - 'spec/integration/ai_integration/publications_integration_spec.rb'
@@ -240,31 +238,17 @@ RSpec/InstanceVariable:
   Exclude:
     - 'spec/integration/ai_integration/publications_integration_spec.rb'
 
-# Offense count: 35
+# Offense count: 43
 RSpec/LetSetup:
-  Exclude:
-    - 'spec/importers/osp_data/osp_xml_builder_spec.rb'
-    - 'spec/importers/yearly_data/yearly_xml_builder_spec.rb'
-    - 'spec/integration/ai_integration/error_redirect_spec.rb'
-    - 'spec/integration/ai_integration/integration_in_progress_spec.rb'
-    - 'spec/integration/ai_integration/ldap_integration_spec.rb'
-    - 'spec/integration/ai_integration/lionpath_integration_spec.rb'
-    - 'spec/integration/ai_integration/osp_integration_spec.rb'
-    - 'spec/integration/ai_integration/publications_integration_spec.rb'
-    - 'spec/integration/ai_integration/yearly_integration_spec.rb'
-    - 'spec/integration/cv_parser_spec.rb'
-    - 'spec/integration/update_works_spec.rb'
-    - 'spec/integration/works_spec.rb'
-    - 'spec/jobs/application_job_spec.rb'
-    - 'spec/models/concerns/work_outputs_spec.rb'
+  Enabled: false
 
 # Offense count: 15
 RSpec/MessageChain:
   Exclude:
     - 'spec/importers/activity_insight/get_user_data_spec.rb'
     - 'spec/models/verify_post_print_spec.rb'
 
-# Offense count: 17
+# Offense count: 25
 # Configuration parameters: .
 # SupportedStyles: have_received, receive
 RSpec/MessageSpies:
@@ -276,7 +260,7 @@ RSpec/MultipleDescribes:
     - 'spec/importers/activity_insight/ai_manage_duplicates_spec.rb'
     - 'spec/models/personal_contact_spec.rb'
 
-# Offense count: 65
+# Offense count: 71
 RSpec/MultipleExpectations:
   Max: 42
 
@@ -297,7 +281,7 @@ RSpec/NamedSubject:
 RSpec/NestedGroups:
   Max: 4
 
-# Offense count: 4
+# Offense count: 6
 # Configuration parameters: AllowedPatterns.
 # AllowedPatterns: ^expect_, ^assert_
 RSpec/NoExpectationExample:
@@ -311,7 +295,7 @@ RSpec/PendingWithoutReason:
   Exclude:
     - 'spec/integration/ai_integration/error_redirect_spec.rb'
 
-# Offense count: 19
+# Offense count: 21
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: Inferences.
 RSpec/Rails/InferredSpecType:
@@ -323,10 +307,17 @@ RSpec/ReceiveMessages:
   Exclude:
     - 'spec/models/post_print_analyzer_spec.rb'
 
-# Offense count: 16
+# Offense count: 2
+RSpec/RepeatedExample:
+  Exclude:
+    - 'spec/models/com_effort_spec.rb'
+
+# Offense count: 18
 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
 RSpec/VerifiedDoubles:
   Exclude:
+    - 'spec/integration/ai_integration/com_effort_integration_spec.rb'
+    - 'spec/integration/ai_integration/com_quality_integration_spec.rb'
     - 'spec/integration/ai_integration/ldap_integration_spec.rb'
     - 'spec/integration/ai_integration/lionpath_integration_spec.rb'
     - 'spec/integration/ai_integration/osp_integration_spec.rb'
@@ -390,7 +381,7 @@ Rails/DynamicFindBy:
     - 'app/controllers/publication_listings_controller.rb'
     - 'app/controllers/works_controller.rb'
 
-# Offense count: 12
+# Offense count: 14
 # Configuration parameters: Include.
 # Include: app/models/**/*.rb
 Rails/HasManyOrHasOneDependent:
@@ -490,7 +481,7 @@ Rails/ThreeStateBooleanColumn:
     - 'db/migrate/20181005135557_change_publication_columns.rb'
     - 'db/migrate/20200220184700_create_integrations.rb'
 
-# Offense count: 30
+# Offense count: 36
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: strict, flexible
@@ -499,6 +490,8 @@ Rails/TimeZone:
     - 'app/controllers/ai_integration_controller.rb'
     - 'app/models/verify_post_print.rb'
     - 'lib/tasks/activity_insight.rake'
+    - 'lib/tasks/com_effort_data.rake'
+    - 'lib/tasks/com_quality_data.rake'
     - 'lib/tasks/ldap_data.rake'
     - 'lib/tasks/lionpath_data.rake'
     - 'lib/tasks/osp_data.rake'
@@ -524,7 +517,7 @@ Style/CaseLikeIf:
     - 'app/importers/pub_data/get_pub_data.rb'
     - 'app/models/concerns/spreadsheet_output.rb'
 
-# Offense count: 18
+# Offense count: 23
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: nested, compact
@@ -581,10 +574,12 @@ Style/IfUnlessModifier:
     - 'app/importers/yearly_data/yearly_xml_builder.rb'
     - 'lib/tasks/activity_insight.rake'
 
-# Offense count: 31
+# Offense count: 52
 # This cop supports unsafe autocorrection (--autocorrect-all).
 Style/LineEndConcatenation:
   Exclude:
+    - 'spec/integration/ai_integration/com_effort_integration_spec.rb'
+    - 'spec/integration/ai_integration/com_quality_integration_spec.rb'
     - 'spec/integration/ai_integration/lionpath_integration_spec.rb'
 
 # Offense count: 6
@@ -613,12 +608,14 @@ Style/OptionalArguments:
   Exclude:
     - 'app/importers/activity_insight/remove_system_dups.rb'
 
-# Offense count: 7
+# Offense count: 9
 # Configuration parameters: AllowedMethods.
 # AllowedMethods: respond_to_missing?
 Style/OptionalBooleanParameter:
   Exclude:
     - 'app/jobs/application_job.rb'
+    - 'app/jobs/com_effort_integrate_job.rb'
+    - 'app/jobs/com_quality_integrate_job.rb'
     - 'app/jobs/delete_records_job.rb'
     - 'app/jobs/ldap_integrate_job.rb'
     - 'app/jobs/lionpath_integrate_job.rb'
@@ -634,11 +631,12 @@ Style/PreferredHashMethods:
   Exclude:
     - 'app/importers/yearly_data/import_yearly_data.rb'
 
-# Offense count: 5
+# Offense count: 6
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: Methods.
 Style/RedundantArgument:
   Exclude:
+    - 'app/importers/com_data/com_effort_populate_db.rb'
     - 'app/importers/ldap_data/ldap_xml_builder.rb'
     - 'app/importers/lionpath_data/lionpath_parser.rb'
 
@@ -669,29 +667,18 @@ Style/RedundantInterpolation:
     - 'spec/models/post_print_analyzer_spec.rb'
     - 'spec/rails_helper.rb'
 
-# Offense count: 1
+# Offense count: 2
 # This cop supports unsafe autocorrection (--autocorrect-all).
 Style/SlicingWithRange:
   Exclude:
+    - 'app/importers/com_data/com_parser.rb'
     - 'app/importers/lionpath_data/lionpath_parser.rb'
 
-# Offense count: 19
+# Offense count: 23
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: Mode.
 Style/StringConcatenation:
-  Exclude:
-    - 'app/controllers/ai_integration_controller.rb'
-    - 'app/controllers/works_controller.rb'
-    - 'app/importers/activity_insight/return_system_dups.rb'
-    - 'app/models/post_print_analyzer.rb'
-    - 'lib/tasks/activity_insight.rake'
-    - 'lib/tasks/ldap_data.rake'
-    - 'lib/tasks/lionpath_data.rake'
-    - 'lib/tasks/osp_data.rake'
-    - 'lib/tasks/pub_data.rake'
-    - 'spec/factories/faculty.rb'
-    - 'spec/factories/publication_listing.rb'
-    - 'spec/integration/ai_integration/lionpath_integration_spec.rb'
+  Enabled: false
 
 # Offense count: 6
 # This cop supports unsafe autocorrection (--autocorrect-all).
@@ -703,7 +690,7 @@ Style/SymbolProc:
     - 'spec/models/concerns/work_outputs_spec.rb'
     - 'spec/rails_helper.rb'
 
-# Offense count: 109
+# Offense count: 121
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, IgnoredPatterns.
 # URISchemes: http, https