Allow for corner radius on stem length and width #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change the length (y dimension) of the stem is `3+dia/2` which is greater than the choc stem recess of `3mm`. See http://www.kailh.com/en/Products/Ks/CS/319.html for reference. This also tidies the total width to not be reliant on the corner diameter either. (True width was `wids*2 + dia`)
HookyKB
changed the title
JeremyBois
added a commit
to JeremyBois/PseudoMakeMeKeyCapProfiles
that referenced
this pull request
Jan 1, 2025
Based on @HookyK pull request pseudoku#7.
JeremyBois
added a commit
to JeremyBois/PseudoMakeMeKeyCapProfiles
that referenced
this pull request
Jan 1, 2025
Based on @HookyK pull request pseudoku#7.
JeremyBois
added a commit
to JeremyBois/PseudoMakeMeKeyCapProfiles
that referenced
this pull request
Jan 1, 2025
Based on @HookyK pull request pseudoku#7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change the length (y dimension) of the stem is
3+dia/2which is greater than the choc stem recess of3mm. See http://www.kailh.com/en/Products/Ks/CS/319.html for reference.This also tidies the total width to not be reliant on the corner diameter either. (True width was
wids*2 + dia)