-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OutputParticles work #339
Merged
Merged
OutputParticles work #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that they are in different cells.
Fortunately they were swapped throughout, so very confusing but not an actual bug...
should work on 2 MPI procs now, too.
The goal being to have the hdf5 specific stuff in one place
That will eventually do all HDF5 specific writing
so that it's persistent and can, next, take care of creating the hdf5 particle type
So we don't need to keep passing this otherwise redundant info around.
Since we already know how many particles we have on a proc.
The number of particles is arr.size()
This particle selector decides whether to include a given particle in the output. Other than the trivial ParticleSelectorAll, ParticleSelectorEveryNth<N> is provided ot select every nth particle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides general cleanup / modernization and preparation for output formats other than HDF5 (ie., ADIOS2), this adds the capability to select a subset of particles to be written. For now, other than selecting all particles, a simple
ParticleSelectorEveryNth<N>
is provided to cut down on the number of particles written.