Add a stub for Criteria

stubs/Collections.phpstub

@@ -170,6 +170,7 @@ interface Collection extends Countable, IteratorAggregate, ArrayAccess
 interface Selectable
 {
     /**
+     * @psalm-mutation-free
      * @return Collection<TKey,TValue>
      */
     public function matching(Criteria $criteria);

stubs/Criteria.phpstub

@@ -0,0 +1,24 @@
+<?php
+
+namespace Doctrine\Common\Collections;
+
+class Criteria
+{
+    public const ASC = 'ASC';
+    public const DESC = 'DESC';
+
+    /**
+     * @psalm-pure
+     */
+    public static function create()
+    {
+    }
+
+    /**
+     * @psalm-external-mutation-free
+     * @param array<string, Criteria::ASC|Criteria::DESC>
+     */
+    public function orderBy(array $orderings)
+    {
+    }
+}

tests/acceptance/Criteria.feature

@@ -0,0 +1,58 @@
+Feature: Criteria
+  In order to use Doctrine Criteria
+  As a Psalm user
+  I need Psalm to typecheck Criteria
+
+  Background:
+    Given I have Doctrine plugin enabled
+    And I have the following code preamble
+      """
+      <?php
+      use Doctrine\Common\Collections\Collection;
+      use Doctrine\Common\Collections\Criteria;
+      use Doctrine\Common\Collections\Selectable;
+      """
+    # Psalm enables cache when there's a composer.lock file
+    And I have empty composer.lock
+
+    @Criteria::create
+    Scenario: Creating a Criteria in a pure context
+      Given I have the following code
+      """
+      /** @psalm-pure */
+      function foo(Selectable $collection): Collection
+      {
+          return $collection->matching(Criteria::create());
+      }
+      """
+    When I run Psalm
+    Then I see no errors
+
+    @Criteria::orderBy
+    Scenario: Order a Criteria in a pure context
+      Given I have the following code
+      """
+      /** @psalm-pure */
+      function foo(Selectable $collection): Collection
+      {
+          return $collection->matching(Criteria::create()->orderBy(['foo' => Criteria::ASC]));
+      }
+      """
+    When I run Psalm
+    Then I see no errors
+
+    @Criteria::orderBy
+    Scenario: Invalid sorting provided to matching
+      Given I have the following code
+      """
+      /** @psalm-pure */
+      function foo(Selectable $collection): Collection
+      {
+          return $collection->matching(Criteria::create()->orderBy(['foo' => 'bar']));
+      }
+      """
+    When I run Psalm
+    Then I see these errors
+      | Type                  | Message                                                                                   |
+      | todo | todo |
+    And I see no other errors