Update vmware_exporter.py to add unit labels #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed a few lines which will add a unit label for the vm_perf and host_perfs
|
Would you be able to update the tests as well? |
|
Ummm, I can take a look but none of this is my expertise so I may not be able to do it correctly |
|
Yeah, I am not sure I am going to be able to update the test. I have been messing around with it for a while and can't even get it to run a successful test before I even make any changes. I tried learning about twisted and the defers but I can't seem to get any of it to work.... Sorry I can't be of more help |
|
Ill take a look at this locally inn the near future and hopefully get the tests updated. Thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed a few lines which will add a unit label for the vm_perf and host_perf.
I noticed that a number of the metrics did not have units listed fot them and thus it was difficult to adequately use them.