Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Tool change be4104a
At some point we broke the tool change. It shows always
?><new tool number>
even when the tool is known.The tool has been reset all the time even during a tool change while unloading and not ONLY when a final UNLOAD has been requested.
Starting with
F1
loaded:Then change from
T0
toT1
Before:
After:
Tested on MK404
Test steps to the second commit:
Flash FW.3.14.0
Connect with serial terminal
Enable MMU
After power up the printer doesn't know which filament is loaded and shows
F?
Preheat the nozzle only Settings -> Temperature -> Nozzle
Send
T0
to load the filament from slot 1 on the MMUNow you can see on LCD
F1
Send
T1
to load the 2nd filamentThis will unload the first filament and then load the second
During this operation watch the LCD screen
12.1. It witches from
F1
to?>2
and finally showsF2
when theT1
command has finishedThe
?
indicates that the filament slot is UNKNOWN13.1. This is correctly shown when the printer starts up
13.2. BUT it should show during the filament change
{current known filament}>{new selected filament}
.This has been working with FW 3.12.2 and MMU 1.0.6 and got broken with FW3.13.x and MMU 3.x.x
Flash firmware with this PR
repeat steps 2 to 12
Now you see it switching from
F1
to1>2
and finally showsF2
when theT1
command has finished16.1 This is the desired output.
Reasons why that happens is that the current firmware "always" reset the filament to UNKNOWN when unload is executed.
The UNKNOWN state should ONLY be set when the filament actually is unknown, which means unloaded for real and not only if the unload of the filament is temporary to be able to load next filament.