selftest: Add allowable fan RPM overlap ranges. #4258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for switched fan detection except for in overlapping ranges which can occur on the XL - Addresses BFW-5677.
|
Hey, sorry, we've already fixed this in our codebase and forgot to inform you that there's no need to update the PR. |
|
Any idea when this will be released?
|
|
I'm not at liberty to give estimates, sorry :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for switched fan detection except for in overlapping ranges which can occur on the XL - Addresses BFW-5677.
Effectively, this change will still allow switched fan detection to work while allowing for an overlap range - which, for many of us (myself included) is a reality on the XL. Switched fan detection is not possible only in this overlap range.
For the other printers using the same firmware base, the overlap has been defaulted to 0 (behavior unchanged), and printers not using the same fan test routine are not impacted.
The idea here is to allow many people, who like to factory reset any time there is a new firmware, to successfully re-run the self-tests without having to remove the shroud from one or more fans on the XL in order to pass the test. This bug has been out there for quite some time and is very impactful to my workflow so I am hoping this can work its way in to a release and alleviate this issue for most.