gcode: Fix issue on unloaded filament temperature being higher temperature than loaded filament (lower temperature) #3681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkerler
force-pushed
the
temperature_load_fix
branch
from
12d0533
to
863d8df
Compare
bkerler
force-pushed
the
temperature_load_fix
branch
from
863d8df
to
7dd8c6c
Compare
We don't have consent from the user right now and they are not encrypted. Shouldn't go to "production". BFW-3468.
…sure getting the filament out of the gear)
Dialog stores the state of underlying screen upon construction and loads it back upon destruction. Consistently. Like, always. Without this, ToolBox::DialogToolActionBox would set focused item which would prevent menu screen from serializing its focused item.
Allow them in redscreen/redscreen. It's already sent proactively, so it's safe. BFW-5207.
Show Enclosure menu only if enclosure is active Change string describing invalid temperature from "N/A" to "--"
This should prevent noices when calibration X axis on XL and improve Tool Offset Calibrations, but only when run as part of selftest, not as gcode (will be done in separate commit/PR) BFW-5322
Small code cleanup. BFW-5322
We shouldn't run any selftest with phasestepping enabled. To prevent running G425 with phase stepping we are disabeling phasestepping temporarily in the gcode it self instead of the selftest state machine. This improves Tool Offset Calibration results when running said calibration on already calibrated machine. The results are not perfect yet. But this change removes the major inaccuracies in the measurements. BFW-5276
We noticed shifts in measured data. Recomend reading BFW-5276 for more details, but in the end slowing down the parking speed helped a lot. BFW-5276
BFW-5335
Fill will be in the next commit BFW-5335
The problem was in write_end_item calling migrate_bank. The function is called in store init, where migrate_bank would screw things. In other cases, the free space for the end item is checked in the parent calling functions. BFW-3553
…sensor_and_user_push__ask BFW-5361
This reverts commit f605a28bea662f02ec8d5121f4f57cee8ada774b.
BFW-5297
Copy pasted from standard printing screen BFW-5371
BFW-5373
…d than filament on load
bkerler
force-pushed
the
temperature_load_fix
branch
from
7dd8c6c
to
bdc65cb
Compare
|
Not sure where to comment, but these tags on GitHub are extremely annoying for those who subscribe to releases via Atom feed. Please consider an alternative approach there. I'm talking about the likes of https://github.com/prusa3d/Prusa-Firmware-Buddy/releases/tag/build%2F6.0.0-BETA%2B7062.PR3681.B4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a configuration store to remember the past filament and does compare if the temperature is lower than the filament that has been unloaded before, and if, does set the last filament temperature only for loading until purging has finished, thus preventing the nozzle to clog.
Fix is related to issue #3585, #3083 and #1821